ZiyaandZiyaZhang
d6d51be4cb
* feat(experimental): ship the two card experiments as one Personalized recommendations bundle @deepseek-ai/dsh-personalized-recommendations inserts the action card service, its browser half, Personalized pages and Plugin recommendations with their card bodies under the existing row ids. As the only layer that declares those ids, the Plugins page addresses and switches each row, including the two shared card rows that were read-only while two bundles inserted them. The two experiment packages stop being bundles; the new bundle takes their place in the official lists and the dsh installation, with the personalized pages icon, localized title and description, and a feature preview of both cards. The two feature rows describe what they do on the bundle page. * fix(experimental): drop the model reason line from plugin recommendation cards The reason follows the language of the user's question while the catalog description below it follows the interface language, so the two lines could differ in language and largely repeat each other; the answer already gives the reason. The card keeps the catalog title and description, both in the interface language, as its details target. * test(web): refresh the card fixtures for the Personalized recommendations bundle Both card replays enable the new bundle, so each Session lists both card skills, and each skill's catalog lists Personalized recommendations in place of the two former bundles. The plugin card goldens lose the reason line. --------- Co-authored-by: ZiyaZhang <199893125+ZiyaZhang@users.noreply.github.com>
apps/web browser e2e
English | 中文
These tests boot the real web composition in-process and drive it with real browsers over real HTTP. Chromium runs the full lane; the model and reasoning picker scenario also runs in WebKit to cover native mouse focus behavior. Session replay recovery also runs in WebKit, sharing the fresh-round-trip recording and expected output without rewriting them. It covers active-stream reload, completed-turn reload, and reopening a Session. The lane's mechanics — modes, fixtures, goldens, and the deliberate composition divergences from dsh web — are documented in scaffold.ts and the browser e2e Agent Note.
After installing workspace dependencies, install the browsers and their system dependencies from the repository root:
pnpm --filter @deepseek-ai/dsh-web-frontend exec playwright install --with-deps chromium webkit
On Linux, --with-deps installs dependencies through the system package manager. The persistent CI VM must provide these dependencies through image maintenance; CI installs only the browser binaries, as required by the failover runbook.
Ordinary scenarios begin with no registered Workspace or Session and a durable marker recording a removed default Workspace, so explicit folder-selection scenarios retain control of their cwd. launchWebScaffold({ firstUse: true }) leaves initialization eligible for startup scenarios.
Same-day message goldens use the shared WEB_FIXTURE_TIME: seeded transcripts pass it as createdAt and pin the browser calendar with pinBrowserClock; scenarios that submit live messages also use pinHostClock and restore it after teardown. These clocks advance with real elapsed time while keeping native timers intact, so midnight does not change a scenario's date labels.
Completion observations
State-sensitive cases use Workspace, admission, attachment, and model-stream barriers to separate visible intermediate states from completed operations. Model-picker persistence assertions wait for the saved default, independently of menu closure. Details close waits for frame transitions; archive verification assigns an explicit title to the seeded Session and follows that identity across reload. The CI test reliability workflow owns these synchronization rules.
Idle-submission handoff waits up to the scaffold's 30-second turn-completion budget for Host frames and browser placement. Vitest owns scaffold teardown so a replay-consumption error does not replace the failed scenario assertion.
Plugin-manager and HMR lifecycle switches wait up to PLUGIN_TOGGLE_SETTLE_MS (10 seconds) for the Host's profile write and the store's follow-up inventory read, the two steps that republish aria-checked; that constant's JSDoc records the measured chain.
Explicit scrolling uses scrollIntoView from support.ts: it resolves the locator again when its old element detaches and checks connection in the same browser task as native scrolling. Scenarios retain their visibility and geometry assertions after scrolling.
Question-composer resize assertions wait for overflow, the clipping mask, and toggle visibility to agree after CSS scroll timelines update.
The snapshot after closing a sidebar pane moves the pointer outside the controls and waits for hover tooltips to close before capture. Keyboard focus remains on the pane.
The same-origin terminal case waits for the UI-triggered Host close operation before checking process termination. It also checks the first window's process, saved bindings and layout after reload.
These are Host-face tests
They type-check in the root tsconfig.host.json, not in the Client aggregate, because they read Host services directly: ctx.connection, the Host SessionStore, and ctx.sessionProjectionCache. Driving a browser at runtime does not make a file part of the Client program — the two faces merge Cordis Context under the same keys with different services, so one program cannot see both. Moving these files into the Client aggregate makes every Host-service access fail to compile.
A new scenario joins both program lists in the same change: its file in the root tsconfig.host.json include and in the Client aggregate's apps/web/tsconfig.json exclude. That project includes all of tests, so a file missing from the exclude compiles as Client code, and the Client compiler gate of pnpm run typecheck keeps failing with Host-service errors until it is listed.
Do not import @deepseek-ai/dsh-client-* here
Importing a Client package — a value or a type — pulls its TypeScript project and referenced projects into the Host build graph. Generated Remote declarations are available before package compilation, but this does not make the Host and Client Cordis Context declarations compatible. Keep these tests on the Host face and use only the explicit built-client harness exception below.
When a scenario needs a Client-owned constant or pure function, mirror it here instead, next to the commented-out import that names the source module. A drift then surfaces as a missed selector or a stale mirrored value — a loud failure, never a silent pass. scaffold.ts follows this rule for the welcome-notice namespace, acknowledgement field, version, and asserted Chinese copy.
The built-client harness is the exception. assembled-boot.ts imports AppWebEntry, the boot-manifest type, and RemoteMock; assembled-remote.ts imports the Client test runtime's default responses and RemoteMock. These packages are explicit project references for booting the real shell against a test-owned carrier. The chat scenarios mirror conversationContextKey in support.ts instead of importing its Client owner.
Nothing mechanically enforces this rule; keep it in review.