diff --git a/.agents/skills/ecc-contribution-review/SKILL.md b/.agents/skills/ecc-contribution-review/SKILL.md index 7fb29bc39..47c43d85b 100644 --- a/.agents/skills/ecc-contribution-review/SKILL.md +++ b/.agents/skills/ecc-contribution-review/SKILL.md @@ -41,8 +41,11 @@ claim as unverified until a reviewer checks its evidence. `--output` writes a new capsule file in the existing parent directory and refuses to overwrite any existing path. The compiler does not create directories, modify source files, run tests, update catalogs, commit, push, - or open a pull request. Exit code 0 means the packet compiled; it does not - mean the change passed review. + or open a pull request. Exit code 0 means a packet was emitted without + reported faults or contradictions; review is still required. Exit code 2 + means validation faults, contradictions, or an input/output error. A + diagnostic packet may still be emitted with exit code 2. Inspect the packet + and stderr; the exit code alone does not establish whether output exists. 6. Review every reported contradiction and semantic page fault. The compiler returns `require_review` for structurally valid input and never approves a diff --git a/.cursor/skills/ecc-contribution-review/SKILL.md b/.cursor/skills/ecc-contribution-review/SKILL.md index 7fb29bc39..47c43d85b 100644 --- a/.cursor/skills/ecc-contribution-review/SKILL.md +++ b/.cursor/skills/ecc-contribution-review/SKILL.md @@ -41,8 +41,11 @@ claim as unverified until a reviewer checks its evidence. `--output` writes a new capsule file in the existing parent directory and refuses to overwrite any existing path. The compiler does not create directories, modify source files, run tests, update catalogs, commit, push, - or open a pull request. Exit code 0 means the packet compiled; it does not - mean the change passed review. + or open a pull request. Exit code 0 means a packet was emitted without + reported faults or contradictions; review is still required. Exit code 2 + means validation faults, contradictions, or an input/output error. A + diagnostic packet may still be emitted with exit code 2. Inspect the packet + and stderr; the exit code alone does not establish whether output exists. 6. Review every reported contradiction and semantic page fault. The compiler returns `require_review` for structurally valid input and never approves a diff --git a/manifests/context-packs/skill-triggers@1.json b/manifests/context-packs/skill-triggers@1.json index 48e292c15..a382ef7f6 100644 --- a/manifests/context-packs/skill-triggers@1.json +++ b/manifests/context-packs/skill-triggers@1.json @@ -10,7 +10,7 @@ "id": "hand-seeded", "source": "manual-curation-pending-regeneration" }, - "registryDigest": "af89f0d6629455a5b2f10173e0196dd0bb8a1998b7ac5919de048cb25bfdcbed", + "registryDigest": "d38a54e7c1a1b22075c20e8935d0d5bf527e6e188335c405f31a1261a2c7f2cd", "schemaVersion": 1, "triggers": { "skill:agent-runtime-gateway-smoke-test": [ diff --git a/skills/ecc-contribution-review/SKILL.md b/skills/ecc-contribution-review/SKILL.md index 7fb29bc39..47c43d85b 100644 --- a/skills/ecc-contribution-review/SKILL.md +++ b/skills/ecc-contribution-review/SKILL.md @@ -41,8 +41,11 @@ claim as unverified until a reviewer checks its evidence. `--output` writes a new capsule file in the existing parent directory and refuses to overwrite any existing path. The compiler does not create directories, modify source files, run tests, update catalogs, commit, push, - or open a pull request. Exit code 0 means the packet compiled; it does not - mean the change passed review. + or open a pull request. Exit code 0 means a packet was emitted without + reported faults or contradictions; review is still required. Exit code 2 + means validation faults, contradictions, or an input/output error. A + diagnostic packet may still be emitted with exit code 2. Inspect the packet + and stderr; the exit code alone does not establish whether output exists. 6. Review every reported contradiction and semantic page fault. The compiler returns `require_review` for structurally valid input and never approves a diff --git a/skills/ecc-contribution-review/docs/WORKFLOW.md b/skills/ecc-contribution-review/docs/WORKFLOW.md index c9803c2bc..65ac9293d 100644 --- a/skills/ecc-contribution-review/docs/WORKFLOW.md +++ b/skills/ecc-contribution-review/docs/WORKFLOW.md @@ -16,9 +16,12 @@ supply chain, coverage, breaking-change status, and budgets. 10. Compile the review packet. The compiler checks supplied claims for shape and internal consistency but does not verify referenced evidence or approve a - contribution. Exit code 0 means the packet compiled; it does not mean the - change passed review. Resolve every contradiction and semantic page fault - before preparing a commit. + contribution. Exit code 0 means a packet was emitted without reported + faults or contradictions; review is still required. Exit code 2 means + validation faults, contradictions, or an input/output error. A diagnostic + packet may still be emitted with exit code 2. Inspect the packet and stderr; + the exit code alone does not establish whether output exists. Resolve + every contradiction and semantic page fault before preparing a commit. 11. The compiler runs no proposed runners. Obtain separate authorization before implementation-file, test, catalog, commit, push, PR, Control Store, canonical-memory, or Semantic Commit effects.