mirror of
https://github.com/affaan-m/ECC.git
synced 2026-11-17 05:22:17 +00:00
feat(clv2): tell instinct-cli users on an end-of-life Python to upgrade
instinct-cli keeps running on old interpreters, but people on one should know they no longer get security fixes. On a Python older than 3.11 (3.10 reached end of life in October 2026) the CLI now prints one line to stderr after parsing its arguments: [instinct-cli] Python 3.8 is past end of life. instinct-cli still runs on it; upgrade to Python 3.11 or newer for security fixes. The command itself runs as before. The notice stays out of automated output: `prune --quiet`, which observer-loop.sh runs, skips it, and CLV2_SKIP_PYTHON_EOL_NOTICE=1 turns it off for anyone who keeps an old Python on purpose. The threshold is one constant, _SUPPORTED_PYTHON, to raise as versions age out. Importing the module prints nothing.
This commit is contained in:
1 parent
6053e1a11b
commit
e41a4a0492
2 files changed
+75
-2
No files matched your search
@@ -6,8 +6,8 @@
|
||||
* interpreter hit it. The static check below parses the script with the 3.6
|
||||
* grammar and rejects the runtime constructs a grammar check cannot see:
|
||||
* unquoted builtin generics in evaluated annotations and newer-only APIs.
|
||||
* The last case runs the CLI under the strictest warning settings of the
|
||||
* current Python.
|
||||
* The other cases run the CLI under the strictest warning settings of the
|
||||
* current Python and cover the end-of-life notice.
|
||||
*
|
||||
* Run with: node tests/scripts/instinct-cli-python-compat.test.js
|
||||
*/
|
||||
@@ -144,6 +144,28 @@ for problem in problems:
|
||||
print(problem)
|
||||
`;
|
||||
|
||||
function loadAndCall(body, env = {}) {
|
||||
const code = [
|
||||
'import argparse, importlib.util, sys',
|
||||
`spec = importlib.util.spec_from_file_location('icli', ${JSON.stringify(cliPath)})`,
|
||||
'm = importlib.util.module_from_spec(spec)',
|
||||
'spec.loader.exec_module(m)',
|
||||
body,
|
||||
].join('\n');
|
||||
const tmp = createTempDir();
|
||||
try {
|
||||
const r = runPython(['-c', code], {
|
||||
env: { CLV2_HOMUNCULUS_DIR: path.join(tmp, 'homunculus'), ...env },
|
||||
});
|
||||
if (r.status !== 0) {
|
||||
throw new Error(`python exited ${r.status}: ${r.stderr || r.error}`);
|
||||
}
|
||||
return r;
|
||||
} finally {
|
||||
cleanupDir(tmp);
|
||||
}
|
||||
}
|
||||
|
||||
console.log('\n=== Testing instinct-cli.py Python compatibility ===\n');
|
||||
|
||||
test('the script uses nothing newer than Python 3.6', () => {
|
||||
@@ -187,6 +209,7 @@ test('commands run with every warning turned into an error', () => {
|
||||
const env = {
|
||||
CLV2_HOMUNCULUS_DIR: path.join(tmp, 'homunculus'),
|
||||
CLAUDE_PROJECT_DIR: projectDir,
|
||||
CLV2_SKIP_PYTHON_EOL_NOTICE: '1',
|
||||
};
|
||||
const sample = path.join(repoRoot, '.claude', 'homunculus', 'instincts', 'inherited', 'ecc-instincts.yaml');
|
||||
const strict = ['-X', 'dev', '-X', 'warn_default_encoding', '-W', 'error', cliPath];
|
||||
@@ -207,6 +230,37 @@ test('commands run with every warning turned into an error', () => {
|
||||
}
|
||||
});
|
||||
|
||||
test('an end-of-life Python gets a one-line notice on stderr', () => {
|
||||
const r = loadAndCall(
|
||||
"m._SUPPORTED_PYTHON = (99, 0)\nm._warn_if_python_eol(argparse.Namespace(command='status'))",
|
||||
{ CLV2_SKIP_PYTHON_EOL_NOTICE: '' }
|
||||
);
|
||||
assert.strictEqual(r.stdout, '');
|
||||
const lines = r.stderr.trim().split(/\r?\n/);
|
||||
assert.strictEqual(lines.length, 1, r.stderr);
|
||||
assert.match(lines[0], /^\[instinct-cli\] Python 3\.\d+ is past end of life\. .*99\.0 or newer/);
|
||||
});
|
||||
|
||||
test('the notice stays quiet for --quiet, the opt-out and a supported Python', () => {
|
||||
const quiet = loadAndCall(
|
||||
"m._SUPPORTED_PYTHON = (99, 0)\nm._warn_if_python_eol(argparse.Namespace(command='prune', quiet=True))",
|
||||
{ CLV2_SKIP_PYTHON_EOL_NOTICE: '' }
|
||||
);
|
||||
assert.strictEqual(quiet.stderr, '');
|
||||
|
||||
const optedOut = loadAndCall(
|
||||
"m._SUPPORTED_PYTHON = (99, 0)\nm._warn_if_python_eol(argparse.Namespace(command='status'))",
|
||||
{ CLV2_SKIP_PYTHON_EOL_NOTICE: '1' }
|
||||
);
|
||||
assert.strictEqual(optedOut.stderr, '');
|
||||
|
||||
const supported = loadAndCall(
|
||||
"m._SUPPORTED_PYTHON = (3, 0)\nm._warn_if_python_eol(argparse.Namespace(command='status'))",
|
||||
{ CLV2_SKIP_PYTHON_EOL_NOTICE: '' }
|
||||
);
|
||||
assert.strictEqual(supported.stderr, '');
|
||||
});
|
||||
|
||||
console.log(`\nPassed: ${passed}`);
|
||||
console.log(`Failed: ${failed}`);
|
||||
process.exit(failed > 0 ? 1 : 0);
|
||||
Reference in new issue
Block a user