With a label in front, as in secret=-----BEGIN RSA PRIVATE KEY-----, the
keyword matcher replaced only "-----BEGIN" and the PEM pattern could no
longer find its opening marker, so the key body was persisted. This was
already the case on main. Move the PEM pattern into _PEM_RE and run it
first in both the observation path and the parse-error fallback.
Running the shape patterns first left suffixes visible: in
password=sk-...<dot>suffix or token=ghp_.../suffix the shape match stopped
at the separator and the inserted "[REDACTED]" kept the keyword matcher
from covering the rest.
Go back to keyword-first and drop the 256-char cap on the keyword value
instead. Its class is disjoint from the separators, so it can run to the
end of the token in linear time. A long labeled key, a labeled password
that starts with a shaped token, and a labeled JWT cut inside a long
payload are now redacted whole.
_SECRET_RE stops after 256 value chars. With it first, a longer
keyword-labeled key such as OPENAI_API_KEY=sk-proj-... lost its prefix
and the shape pattern could no longer see the rest, so the tail was
persisted. Running _SECRET_VALUE_RE first fixes both the observation
path and the parse-error fallback; "[REDACTED]" is outside the keyword
value class, so the second pass leaves it alone.
The sk- and JWT branches capped their token classes at 512 and 1024
chars, so a longer value was only partly replaced. Their classes do not
overlap with the separators, so they can run to the end of the token
and still match in linear time.
The end-of-text match for a key or JWT cut by truncation moves to its
own pattern, applied only when the capture was actually shortened.
Short output that happens to end in "sk-learn" or a one-segment eyJ
blob stays readable.
Observations are cut to 5000 chars (2000 in the parse-error fallback)
before scrubbing. A JWT cut inside its payload lost its second dot and a
key cut short of 20 body chars missed the length floor, so the remaining
header, claims or key prefix were persisted. Accept a match that runs to
the end of the capture, the same way the PEM and DSN branches do.
Tests cover both cuts in string output, structured output and the
parse-error fallback, and compare the JWT and Bash cases against their
exact expected values.
observe.sh only redacted Anthropic and OpenAI keys when a keyword such as
api_key or token sat in front of them, so `echo <key> > key.txt` and file
content holding a key were written to observations.jsonl in plain text.
JWTs had the same gap.
Add value-shaped branches to _SECRET_VALUE_RE in both the observation and
parse-error paths: sk-ant-, sk-proj-, sk-svcacct-, sk-admin- and sk-or-
keys, legacy alphanumeric sk- keys, and eyJ JWTs. Quantifiers are bounded
and the branch only starts at a token boundary, so the matcher stays linear.
Refs #3846
Reject numeric prefixes, fractions and unsafe window integers consistently with summary scheduling while preserving resolver precedence. Cap only the default context reminder at eighty percent of a valid earlier native compaction budget; explicit thresholds, including zero, retain their intentional policy. Document the independent capacity, summary and advisory contracts.
RED controls reproduce malformed-budget summary triggers and the known-1M/native-200k missed reminder. Resolver65, helper47, actualStop18 and actualPreToolUse54 pass on Node18 and24. Parent and independent reviewer approved the exact diff before commit. Registry rebinding remains the integration coordinator responsibility after combining documentation repairs.
Include captured stderr, status, signal and spawn error message when the existing unexpected-monitor-failure warning assertions fail. Preserve all status/raw-input/warning assertions, deadlines and product bytes.
The macOS hosted failure did not print its actual stderr, so its transient cause remains unverified. The unchanged source matches green main; 24 prior local diagnostic repeats passed 120 checks. This diagnostic-only patch passes all five fixture cases, affected ESLint and diff checks. Parent independently reviewed the diff. Fresh exact-head hosted CI remains required.
Zero the 32-byte r scalar while preserving the signature encoding, length, s and recovery byte. The previous tail overwrite could leave r/s unchanged and normalize recovery 27 to 0, preserving a valid payment. Keep and strengthen no-claim/no-handler/no-settlement checks before serving the original valid payment.
Restore the shipped payload-first contract from #3464/#3495 and the explicit source #3755 scope clarification. Two provider conversations must retain distinct IDs despite an inherited registered ECC parent ID. Normal and ambient producer24 tests, canonical resolver10 and independent differential review pass. Keep native importer guards; explicit provider/native correlation is queued separately.
Clarify native compaction budget scheduling independently of the model window resolver and retain immutable transcript fixtures. Helper43, ten independent scheduling controls, affected lint and independent review passed.
Verify review discussion4419348312 against actual native producer/importer behavior. Prefer the independently sanitized ECC_SESSION_ID for the ECC-owned metrics feed, retain payload then legacy fallback for standalone hooks, and leave sibling hooks unchanged.
Actual Node producer plus read-only cached native binary reproduces zero imported metrics before the fix and exactly one tool/file/log after repeated sessions/status commands. Four producer regression controls and normal/adversarial inherited-env suites pass22/22. Focused coverage96.47percent lines and91.47percent branches; parent independent source review passed.
Separate confirmed model capacity from Stop-summary scheduling. Use the smaller confirmed capacity/native budget, or native-only budget for inferred capacity. Three unit and one actual hook RED cases now pass; helper43, actualStop15 and ten independent controls pass without changing the capacity resolver.
Verify and address PR #3809 discussions 4419228221, 4419257840 and 4419257844. Iterate string-array assertions through sparse positions, validate the declared example identifier grammar before request construction, and refresh Turkish/Chinese reviewer references. Regenerate the canonical Pi copy.
Compile and execute the actual typed fixture; keep published validation bodies aligned and prove invalid identifiers never call fetch. RED: 28 pass, 2 fail. GREEN: 30 pass, 0 fail. Strict tsc, changed ESLint/Markdownlint, Unicode/agent/skill validators and deterministic Pi checks pass. Parent independently reviewed all six paths. Registry rebinding is deferred to the combined integration.
Carry forward AbhiramMandala’s canonical TypeScript guidance from PR #3142, reviewed source head 643f61d604. Rebuild current-main counts, Pi projection and trigger digest without replacing existing registry entries.
Use bracket access under the documented noPropertyAccessFromIndexSignature baseline. Type-check and execute the actual fixture, compare published function bodies, and preserve deterministic undefined, sparse-array and concurrency regressions.
Validation: 26 focused checks; strict TypeScript compile; all repository validators; affected ESLint and Markdownlint; deterministic Pi rebuild; real npm pack; disposable Claude, Codex and Copilot install/repair/uninstall with exact skill bytes and preserved user files. Parent independently reviewed the complete staged diff.
Co-authored-by: AbhiramMandala <abhirammandala02@gmail.com>
Dropping the previous-character check in toggleQuote let the `'` of `\'` close an ANSI-C `$'...'` string, so `echo $'it\'s'; (rm -rf /tmp/x)` left a quote open and the group was never extracted. Track `$'...'` in the quote state and consume backslash escapes inside it, as bash does, and cover the inner scanners (`(...)`, `$(...)`, `{ ...; }` bodies) with quotes ending in a backslash.