Commit Graph
726 Commits
Author SHA1 Message Date
haelyra 73d2a0b28b Merge remote-tracking branch 'origin/pr-3910' into stewardship/20261116 2026-11-16 13:24:33 -05:00
haelyra c7315cd673 Merge remote-tracking branch 'origin/pr-3909' into stewardship/20261116 2026-11-16 13:24:33 -05:00
haelyra 8d78e08609 Merge remote-tracking branch 'origin/pr-3933' into stewardship/20261116 2026-11-16 13:22:31 -05:00
haelyra 66aede496c Merge remote-tracking branch 'origin/pr-3926' into stewardship/20261116 2026-11-16 13:20:47 -05:00
Neo 8f0dd2ca3a fix(eval): record fulfilled async tool responses 2026-11-13 15:17:43 -05:00
montjeffrey bf7f495a53 fix(harness): canonicalize source_doc containment with native realpath
Resolve both sides of the source_doc containment check with
fs.realpathSync.native (falling back to fs.realpathSync). With the JS
realpath, a repo root reached through a Windows 8.3 short name stays in
short form while an in-repo symlink whose target uses the long-path form
resolves to the long form, so a legitimate in-repo doc was reported as
"resolves outside repository root". Escapes outside the repo are still
rejected.

Adds a cross-platform regression test that models differing JS and
native realpath results: in-repo docs are accepted through a short-form
root and an outside target is still rejected. It fails on the previous
implementation.

Not required for the #3882 Windows CI fix; kept as a separate commit so
it can be taken or dropped on its own.
2026-11-12 00:21:26 -05:00
yuhoyuho bcad1b982c fix(control-pane): bound action output capture and preserve streamed UTF-8 2026-11-12 09:36:35 +09:00
Afloat 21ae946484 fix(project-detect): reject invalid quoted module paths 2026-11-11 21:50:26 +08:00
Afloat b7de3157fd fix(project-detect): decode quoted Go module tokens 2026-11-11 21:41:52 +08:00
Afloat 82bf65024f fix(sessions): preserve complete Markdown sections 2026-11-11 21:30:15 +08:00
Afloat bbdfd133e0 fix(project-detect): read all Go require directives 2026-11-11 21:13:09 +08:00
montjeffrey cefc906288 fix(grok): compare worktree roots with native realpath on Windows
GitHub Windows runners use an 8.3 short path for os.tmpdir()
(C:\Users\RUNNER~1\...). git rev-parse --show-toplevel returns the long
path, but JS fs.realpathSync does not expand 8.3 short names, so
isGitWorkTreeRoot compared unequal for a valid worktree and source
preparation fell through to the registry branch and threw.

Prefer fs.realpathSync.native (falling back to realpathSync for injected
fakes) in isGitWorkTreeRoot and findRegistrySource. Fail-closed behavior
is unchanged. Adds cross-platform and Windows-only regression tests.

Fixes the windows npm/full lane on #3882.
2026-11-09 22:07:06 -05:00
haelyra b2ea647d41 fix: reconcile combined integration test contracts 2026-11-05 23:53:59 -05:00
haelyra 8da4a5f858 fix: preserve reviewed OpenCode install migration 2026-11-05 23:40:25 -05:00
haelyra 4b0bac4ba2 Merge reviewed PR #3854 2026-11-05 23:38:59 -05:00
haelyra a032472448 Merge reviewed PR #2856
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
2026-11-05 23:28:21 -05:00
haelyra 001df488e5 fix: reconcile reviewed integration repairs and generated catalogs 2026-11-05 23:26:12 -05:00
haelyra ba3042a85d Merge reviewed PR #2496 2026-11-05 23:13:00 -05:00
haelyra c054b3053c Merge reviewed PR #3811 2026-11-05 23:12:33 -05:00
haelyra ee1ec55232 Merge reviewed PR #3820 2026-11-05 23:12:13 -05:00
haelyra 5e170cfa10 Merge reviewed PR #3813 2026-11-05 23:12:13 -05:00
haelyra 917ed1fd2c Merge reviewed PR #3873 2026-11-05 23:11:46 -05:00
haelyra c20ca2f20c Merge reviewed PR #3872 2026-11-05 23:11:46 -05:00
haelyra 01e4f8bd44 Merge reviewed PR #3864 2026-11-05 23:11:09 -05:00
haelyra fceb970215 Merge reviewed PR #3862 2026-11-05 23:11:09 -05:00
haelyra 912fc63c41 Merge reviewed PR #3671 2026-11-05 23:10:45 -05:00
haelyra ab10daba18 Merge reviewed PR #3870 2026-11-05 23:10:32 -05:00
Cheese 4385863e56 fix(scripts): reject inherited package manager names 2026-11-06 11:52:10 +08:00
Rahul Selvaraj feac4f52ba fix(hooks): match the full classifier notice, isolate test env
CLASSIFIER_NOTICE matched by prefix, so a pasted notice followed by a
user question was dropped from both summary paths. Anchor it to the
whole message so trailing user text is kept, and add a regression test.

Also pass ECC_SKIP_LLM_SUMMARY=1 in the withTranscript fixture helper so
an inherited ECC_LLM_SUMMARY_INTERVAL=1 cannot trigger claude -p.

Refs #3867

Assisted-by: Claude <noreply@anthropic.com>
2026-11-06 08:47:21 +08:00
L4XB 30eb570117 fix(hooks): read NUL-ended delimiters, Bash blanks before #, and long bodies
Bash ends a decoded $'...' string at its first NUL, so `cat <<$'EOF\0X'`
ends at the line EOF, but the splitter looked for EOF\0X and swallowed
the commands after the body. A carriage return or a no-break space is
not a blank to Bash, so `echo foo\r# && npm run dev` runs the dev
server, but the splitter read the # as a comment. And spreading a long
substitution's segments into push() threw RangeError, which the hook's
catch turned into an allow. Truncate the decoded part at the NUL, use
Bash's blanks for word starts, and append the segments one at a time.
2026-11-05 13:07:21 +01:00
Rahul Selvaraj 846a561a7b fix(hooks): drop classifier notices from LLM summary input
The safety-classifier notice filter only covered the mechanical summary.
When generateSessionSummary runs (low context or message interval),
extractConversationText read the raw transcript and passed the notice to
the LLM as a user turn, so it could still reach saved context.

Move the check into one shared isClassifierNotice() in
scripts/lib/llm-summary.js and use it in both userMessageText() and
extractConversationText(). Add LLM-path regression tests, and split the
session-end classifier-notice tests into small functions (<50 lines).

Refs #3867

Assisted-by: Claude <noreply@anthropic.com>
2026-11-05 18:06:51 +08:00
L4XB 04f32e06e7 Merge remote-tracking branch 'origin/main' into fix/shell-split-newlines 2026-11-05 10:27:19 +01:00
L4XB 80a26c2ceb fix(hooks): read $$ as the process ID before looking for $'...'
In `echo $$'\'; npm run dev`, Bash reads `$$` as the process-ID parameter
and the quote after it as an ordinary single quote, so it runs
`npm run dev`. The splitter took the second `$` as the start of ANSI-C
quoting, which hid the semicolon, and a here-document delimiter such as
`$$'EOF'` was read as `$EOF`, so the body never ended. Consume the `$$`
pair first in both places.
2026-11-05 10:27:19 +01:00
haelyra 7a0188db61 fix(hooks): honor Bash quote boundaries in dev guard
(cherry picked from commit f4bf43c550)
2026-11-05 10:23:23 +01:00
kevin 3d7034872e fix(memory): scan decoded fields for secrets, not serialized JSON 2026-11-05 06:27:55 +09:00
kevin cfe051de5f fix(memory): flag GitHub ghu_ tokens as suspected secrets 2026-11-05 06:19:48 +09:00
huangpz6andTRAE 01c2426b2c fix(gateguard): classify settings through real paths and .claude project roots (#3862)
A symlink alias to .claude/settings.json resolved past the lexical settings check, and a project whose root is .claude collapsed the class path to bare settings.json. Judge the resolved absolute path and the symlink-resolved path as well, with regressions for both.

Co-Authored-By: TRAE <noreply@trae.ai>
2026-11-04 21:52:33 +08:00
huangpz6andTRAE cdb8a93819 fix(hooks): share one recovery-hint parser and cover default denials (#3864)
Move ECC_SHOW_RECOVERY_HINTS parsing into scripts/lib/hooks/recovery-hints.js so every hook trims and accepts the same truthy values. Add default-off and opt-in assertions for the condensed GateGuard denial, config-protection (protected and truncated payloads) and the fail-closed truncation wrapper.

Co-Authored-By: TRAE <noreply@trae.ai>
2026-11-04 21:36:43 +08:00
huangpz6andTRAE dde2c8dbda fix(gateguard): treat .claude/settings files as restricted for subagents too (#3862)
Removing the exemption gated top-level edits, but subagent Edit/Write/MultiEdit still consult only sensitive or hard-linked targets, so an ordinary settings file bypassed the gate. Classify .claude/settings*.json as sensitive in the shared target class and cover all three subagent edit tools plus both settings file names.

Co-Authored-By: TRAE <noreply@trae.ai>
2026-11-04 21:24:45 +08:00
MohammadAminDHM 76f8ea4bd3 fix(opencode): address round-2 review findings on the hooks surface
- R2-1: the V2 execute.after adapter passed { result: ... } as the tool
  output; skill-run-tracker derives outcomes from error fields on the
  response itself, so failed skills recorded as successes. The adapter
  now forwards the raw event.result ?? event.output. Covered by a T05
  assertion that an is_error skill event records outcome failure and a
  clean event still records success.
- R2-2: cmd.exe expands %VAR% and honors embedded quotes even inside
  double quotes, so escaping " was unsafe. spawnCommand now refuses
  arguments carrying ", %, CR or LF (nothing spawns; the rejection
  surfaces through the formatter's catch) and emits the canonical /s
  form with one outer quote pair around the whole command. T01 asserts
  the outer pair, strips it before inspecting the inner quoting, and
  covers two refusal payloads.
- R2-3: repo review rules ban console.log; the client-less log fallback
  and the startup line now use console.info (identical stdout behavior).
- R2-4: declined installs recorded before the barrel split retained the
  old module/factory stub in plugins/index.ts, and a later selective
  install (e.g. commands-core) has no operation rewriting it, so the
  strict deactivation gate failed the install after all writes landed.
  The strict branch now migrates such retained files in place only when
  ownership is proven twice (managed-recorded contentSha256 matches disk
  AND disk equals an exact historical disabled-stub payload), written
  through writeFileNoFollow with that digest as expectedContent;
  anything else keeps failing closed. The preflight branch accepts an
  already-inactive recorded config under the same digest-verified
  condition, since selective installs legitimately plan no .opencode
  writes. New lifecycle test covers both the migration (install ok,
  doctor clean, ownership retained) and the refusal path (mis-recorded
  digest never grants a rewrite).
2026-11-03 20:13:58 +03:30
MohammadAminDHM 6286b7c2f1 fix(opencode): address review findings T01-T15 on the V2 plugin surface
P0: spawnCommand() replaces shell:true (cmd-shim routing with /d /s /c, quoted argv, windowsVerbatimArguments); permission.ask no longer auto-approves formatter/test shell prefixes; detached spawns register the error listener before resolving.

P1: loadToolModule probes .js then .ts for dist and source layouts; V2 setup() tests via mock ctx; installer recognizes every historical plugin registration (./plugins and plugins/ecc-hooks.*) via shared isOpenCodeHookConfigRegistration(); ecc-universal ./plugins export repointed to the live dist/plugins/ecc-hooks.js; opencode.json drops the file-path plugin entry OpenCode 2.x ignores, docs updated.

P2: setup() rolls back registrations and releases the directory guard on mid-setup failure; prettier non-zero exits reported as warn; subscription errors discriminated against abort; disposals awaited without unhandled rejections; windowsHide on all spawns; TROUBLESHOOTING curl passes location[directory].

Tests: opencode-plugin-hooks 22/22 (new T01/T02/T03/T05/T10/T11/T13/T14 coverage), build-opencode 11/11 (new T08 export test), hook-consent 12/12, install-executor 26/26, install-lifecycle 73/73, plugin-manifest 71/71.
2026-11-03 18:59:18 +03:30
Misty-Star d12137e1b7 fix: adapt Grok hooks for Windows tool execution 2026-11-03 18:59:28 +08:00
YuhaoLin2005 95bf86c348 Add config-health monitor and install wiring
- Add the config-health skill: a read-only monitor for hook wiring, rule references, and rule staleness; every mode exits 0.
- Ship its own SessionStart hook asset so installing the module registers the monitor; keep PreToolUse opt-in.
- Keep one install-state record per hook source, so hooks-runtime and config-health can share settings.json and uninstall removes both.
- Split the monitor into a CLI entry plus constants, paths, and scan modules; split scan_command and the hook contract suite. All files are under 800 lines and no function body reaches 50 lines.
2026-11-02 22:53:30 +08:00
Misty-Star 34c20e751b Merge remote-tracking branch 'origin/main' into pr/2856
# Conflicts:
#	manifests/context-packs/skill-triggers@1.json
2026-11-02 16:00:47 +08:00
Misty-Star 06f6008165 merge: resolve PR 2856 conflicts with main 2026-11-02 15:35:10 +08:00
Yann Roberto f8b9a40436 fix(scripts): recognize npm-shrinkwrap.json 2026-10-30 21:34:21 +08:00
Yann Roberto 1a6cbb6716 fix(install): preserve Copilot user script scopes 2026-10-30 18:57:51 +08:00
Yann Roberto c68afd7c35 fix(install): isolate Copilot helpers from ESM projects 2026-10-30 18:31:48 +08:00
minteeqahmed-png 6441dd1370 fix(harness): use segment-aware root containment and explicit symlink skip 2026-10-30 14:49:03 +05:00
minteeqahmed-png 6f611d7a6a feat(harness): add Antigravity, Qwen, Copilot, and Hermes to compliance matrix 2026-10-30 14:32:18 +05:00