A comment that opened after text in a list item and closed in a later
block quote hid the live link between them, because the paragraph check
only looked for blank lines. Read a comment across lines only where
CommonMark makes it a top-level HTML block, a `<!--` at column 0 after a
blank line, which only its closer ends. Elsewhere a comment is hidden
only when it closes on the line it opens on, so every other line stays
audited Markdown. The fence pass uses the same rule for comment blocks.
Drop the container and ordered-list heuristics this replaces, refresh
the registry digest, and keep the three copies of the script identical.
Add a Supporting Files index to the canonical and Pi-packaged skill so examples, references, the report template, and the evaluator script are discoverable from SKILL.md. Replace bare path mentions with working relative links.
Addresses one item from #3783.
Verify and address PR #3809 discussions 4419228221, 4419257840 and 4419257844. Iterate string-array assertions through sparse positions, validate the declared example identifier grammar before request construction, and refresh Turkish/Chinese reviewer references. Regenerate the canonical Pi copy.
Compile and execute the actual typed fixture; keep published validation bodies aligned and prove invalid identifiers never call fetch. RED: 28 pass, 2 fail. GREEN: 30 pass, 0 fail. Strict tsc, changed ESLint/Markdownlint, Unicode/agent/skill validators and deterministic Pi checks pass. Parent independently reviewed all six paths. Registry rebinding is deferred to the combined integration.
Carry forward AbhiramMandala’s canonical TypeScript guidance from PR #3142, reviewed source head 643f61d604. Rebuild current-main counts, Pi projection and trigger digest without replacing existing registry entries.
Use bracket access under the documented noPropertyAccessFromIndexSignature baseline. Type-check and execute the actual fixture, compare published function bodies, and preserve deterministic undefined, sparse-array and concurrency regressions.
Validation: 26 focused checks; strict TypeScript compile; all repository validators; affected ESLint and Markdownlint; deterministic Pi rebuild; real npm pack; disposable Claude, Codex and Copilot install/repair/uninstall with exact skill bytes and preserved user files. Parent independently reviewed the complete staged diff.
Co-authored-by: AbhiramMandala <abhirammandala02@gmail.com>
Add a GitHub issue counterpart to the PR mode of /code-review. The
canonical workflow lives in skills/issue-review and walks nine phases:
fetch the issue with gh, build project context, classify type and
completeness, verify the claim against the code at HEAD, search for
duplicates and prior fixes, assess severity and decision, write a
review artifact with a draft reply, publish only on explicit flags,
and print a one-screen summary.
Issue text is treated as untrusted data: embedded instructions are
never followed, pasted code is never run, and arbitrary links are not
fetched. Writing to GitHub is opt-in via --comment or --label and the
workflow never closes, reopens, or assigns issues.
commands/issue-review.md is the thin slash-command shim. The new
structural test guards the frontmatter, required sections, phase
order, safety invariants, and registration on every surface.
Register the skill and command in package.json, agent.yaml, the
operator-workflows install module, the quick reference, the
command-agent map, and the README; regenerate the command registry
and sync catalog counts to 312 skills and 98 commands.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Tomoya.Fujita <fujita.tomoya@triorb.co.jp>
The sync.Pool example returned buf.Bytes(). That slice points into the
pooled buffer. The deferred Reset and Put give the buffer to the next
Get, so another goroutine can overwrite the result while the caller
still uses it.
Return bytes.Clone(buf.Bytes()) instead, and add a short note. Same code
fix in the five translations. pi/core regenerated with
scripts/build-pi-core.js.
Tested: 64 goroutines calling the example under go test -race (Go 1.27).
Old code: DATA RACE and wrong results. New code: passes.
node scripts/build-pi-core.js --check passes.
Replaces the golang part of closed PRs #3351 and #3405, which were not
merged.
Integrate contributor PRs #3533, #3534, and #3535 on current main. Preserve the read-only module audit, canonical glossary and ADR ownership, and opt-in install closure. Refresh only the manual trigger manifest registry binding and coverage after adding the skill.
Sources: #3689#3691#3692#3693. Preserve Claude marketplace migration guidance, tool-result boundaries, scoped workflow authority, and bounded batch preparation. Regenerate the Pi projection and recompute the shared registry digest on one main head.
An indented line such as ' continued' after '1. first' continues the list item, so the '2.' after it starts the next item, and a comment there opens a block. The paragraph check took the indented line for a paragraph line and left the comment inline.
A list that starts at a number other than 1 cannot interrupt a paragraph, so 'Paragraph\n2. <!-- c --> [x](y)' is one paragraph whose comment is inline and whose link is real. The marker opened a comment block and hid the link. After a paragraph line, such a marker now leaves the comment inline. After a blank line, a list line or a '1.', it still opens a block.
Only indentation counted as the start of a block, so '- <!--' was inline HTML, and a blank line before its closer turned it into text. Its hidden links were then reported. Block quote and list markers before the opener now count too, as in CommonMark. A comment after text in a list item stays inline.
CommonMark reads a comment that starts a line, after at most three spaces, as an HTML block. The block may span blank lines, and it takes the rest of the line that holds its closer, so a link after '<!-- c -->' at the start of a line is raw HTML, not a link. A comment inside a line is inline HTML, which cannot outlast its paragraph: past a blank line its opener is text, and a link before the later closer is real. The scan keeps the first closer and the first blank line after an opener while they stay valid, so it remains linear.
A title may hold comment-shaped text, as in [x](missing.md "<!-- c -->"). The filter for blanked comments looked at the whole target, title included, so it dropped that link and its broken destination went unreported. The filter now strips the title first, with the same pattern normalize_link_target uses, which moves to LINK_TITLE_RE.
A fence line inside an HTML comment block opened a fence that ran past the comment's closer, so the comment then had no closer and a link inside the real fence after it was audited. The fence pass now skips comment blocks that open at the start of a line. A destination made only of a blanked comment, as in [bar]: <!-- c -->, is no longer returned as a link target.
Code spans were blanked before comments, so a code span could swallow a comment's closer and the comment then hid a real link after it. Comments and code spans are now read left to right, whichever opens first. An escaped \<!-- is text, and a comment becomes an opaque run of NUL characters rather than spaces, so a reference definition can no longer start across it.
The audit read links inside <!-- --> comments, so a commented-out link to a removed or planned page was reported as a broken Markdown link. Blank out closed HTML comments after code is removed, the same way code examples are already skipped; an opener without a closer stays literal text, as in CommonMark. The three copies of markdown_links.py stay identical, and the skill trigger manifest's registry binding is refreshed for the changed skill files.
The AJAX example reads csrftoken from document.cookie, which fails when
CSRF_COOKIE_HTTPONLY is True. Drop the setting from the production
block (the default is False) and set it to False in the CSRF block, as
the .kiro copy already does there. Also remove SECURE_BROWSER_XSS_FILTER,
which Django 4.0 removed. Updated .kiro and regenerated pi/core.
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit bdc4407edf)
Perl::Critic has no InputOutput::RequireThreeArgOpen or
Modules::RequireTaintChecking policy. perlcritic warns that they are
not installed and ignores them. Two-arg open is already covered by
InputOutput::ProhibitTwoArgOpen in the same profile. Regenerated pi/core.
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit d70726d79c)
sanitize_html is not a built-in Laravel rule and the skill never
registers it, so the validator throws BadMethodCallException. The same
FormRequest already strips tags in validated(). Regenerated pi/core.
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit 453c0651f7)
The users router uses Depends() for OAuth2PasswordRequestForm but the
import line omits it, so the module raises NameError on import.
Regenerated pi/core with scripts/build-pi-core.js.
Signed-off-by: Wen <jwcastillo@gmail.com>
(cherry picked from commit d383fb57e9)
Preserve complete source ancestry for PRs #3512, #3513, #3515, #3516, #3517 and #3518. Repair bounded recovery, alias compatibility and evaluator packaging gaps while keeping registry reuse inside the canonical loader. Verified actual hook, setup, dashboard, evaluator, sandbox and profile workflows plus full npm, Python, lint and supply-chain checks. ECC-043 preparation only; integration remains with the delivery owner.