Commit Graph
12 Commits
Author SHA1 Message Date
haelyra 324c4187ba Merge reviewed PR #3860 2026-11-05 23:24:35 -05:00
haelyra a0e6eb56e4 Merge reviewed PR #3830 2026-11-05 23:24:06 -05:00
haelyra 917ed1fd2c Merge reviewed PR #3873 2026-11-05 23:11:46 -05:00
kevin 3d7034872e fix(memory): scan decoded fields for secrets, not serialized JSON 2026-11-05 06:27:55 +09:00
kevin cfe051de5f fix(memory): flag GitHub ghu_ tokens as suspected secrets 2026-11-05 06:19:48 +09:00
Codex f841420f22 ci: parallelize Windows full tests and preserve fixture isolation
Run the Windows full suite with two workers while retaining serial suites and exact file accounting. Resolve Bash before restricting fixture PATH, and add five junction regressions while retaining native symlink coverage.

Validation: both local full runs executed all 456 files exactly once; 9108 passed and the same 24 symlink-permission cases failed. Two workers reduced local runtime from 1324.987s to 885.387s. The 24 native symlink cases passed in the baseline GitHub Windows job.
2026-11-04 09:30:26 +09:00
Brian fbd14b4431 test: skip inside the cleanup scope so fixtures are always removed
Review on #3830 found that memory-vault's symlink guard sat above the
try/finally that removes the fixture, so a refusal returned before
cleanup and left the directory in the OS temp dir.

Auditing the other guard sites turned up the same shape in memory-mcp,
where binRoot is created before the guard and only removed in the
finally. Six leaked ecc-memory-bin-* directories were still sitting in
this host's temp dir from earlier runs.

Both guards now sit immediately inside the try. Verified by counting
ecc-* temp directories either side of a run of both files: delta 0.

The remaining guard sites were checked and are already inside their
cleanup scope.
2026-10-31 13:54:10 -04:00
Brian 0aa90931c4 test: build the artifact list without mutating it
Review on #3830 raised two points against 2f898d7b.

The three artifacts.push calls mutated an array after creating it, which
AGENTS.md rules out ("Immutability (CRITICAL): Always create new objects,
never mutate"). The list is now a single literal with conditional
spreads, so the link-based cases still join it only where the OS allows
the link.

In memory-vault, the readRegularTextFile check on the target reads no
link at all, so the symlink guard now sits below it rather than above.
On a host that refuses the link, that assertion runs instead of being
skipped with the rest.
2026-10-31 13:35:52 -04:00
Brian 09de2c247a test: skip symlink tests when the OS refuses symlink creation
Adds a trySymlink helper that logs the existing skip notice and returns
false on EPERM/EACCES/ENOSYS, and uses it where tests created symlinks
unguarded. Non-admin Windows accounts without Developer Mode now skip
these cases instead of failing.
2026-10-26 15:08:05 -04:00
Affaan Mustafa 90ef62cb1d fix(memory): distinguish incomplete reads from missing records
Independent local Codex review PASS at 73b07f8d17, no P0/P1. Independent 66 tests and strict validation of 810 skills passed. CI run 34683976362 passed; all 48 current checks green. Incomplete memory reads fail closed with safe MCP diagnostics; canonical guidance synchronized across harness skill copies. Rollback: revert this squash commit. No deployment or installation claim.
2026-09-12 05:52:29 -04:00
Kumar Prateek 51a6950bde fix(memory-vault): compare dev only when both stats report one (#2637)
ecc memory writes and --body-file reads fail on Windows. sameFileIdentity()
compares the dev field of a path-based stat against a handle-based fstat, and
libuv 1.49.0 through 1.50.x resolve path-based stat() and lstat() on Windows
through GetFileInformationByName, which leaves the volume serial unset while
fstat() reports it. The comparison never matches, so the TOCTOU guard rejects
every operation.

Keep the inode strict and compare dev only when both sides report one. POSIX
always reports a non-zero dev, so the original strict behaviour is preserved
there.

Request the guard's stats as BigInt. On the affected libuv versions dev is 0,
which leaves the inode as the only identity signal, and Windows file IDs run
past Number.MAX_SAFE_INTEGER where two distinct files can collapse to the same
number-valued inode.

Fixes #2626
2026-08-08 17:06:18 -04:00
Affaan Mustafa 4d0b501b05 feat: add cross-harness memory vault (#2581)
Add a local-first, cross-harness memory vault with CLI and MCP surfaces, bounded search and storage, harness-scoped visibility, setup guidance, and comprehensive tests.
2026-07-26 02:46:59 -07:00