OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-04 09:11:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

split || if statements, remove unneeded parts

Browse Source
This commit is contained in:
Karim Fadel 2026-01-14 07:13:40 +02:00
parent b3c825097a
commit 09d4e84008
1 changed files with 13 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
Java-Approvals/src/main/java/com/gildedrose/GildedRose.java
View File

@ -12,19 +12,17 @@ class GildedRose {
public void updateQuality() { public void updateQuality() {
for (int i = 0; i < items.length; i++) { for (int i = 0; i < items.length; i++) {
if (items[i].name.equals(AGED_BRIE) if (items[i].name.equals(AGED_BRIE)) {
|| items[i].name.equals(BACKSTAGE_PASSES)) { incrementQualityByOne(i);
} else if (items[i].name.equals(BACKSTAGE_PASSES)) {
incrementQualityByOne(i); incrementQualityByOne(i);
if (items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].sellIn < 6) {
if (items[i].sellIn < 11) { increaseQualityByTwo(i);
incrementQualityByOne(i); } else if (items[i].sellIn < 11) {
} incrementQualityByOne(i);
if (items[i].sellIn < 6) {
incrementQualityByOne(i);
}
} }
} else { } else {
decreaseQualityByOne(i); decreaseQualityByOne(i);
} }
@ -47,6 +45,11 @@ class GildedRose {
} }
} }
private void increaseQualityByTwo(int i) {
incrementQualityByOne(i);
incrementQualityByOne(i);
}
private void decreaseQualityByOne(int i) { private void decreaseQualityByOne(int i) {
if (items[i].quality > 0) { if (items[i].quality > 0) {
if (!items[i].name.equals(SULFURAS)) { if (!items[i].name.equals(SULFURAS)) {