From 75e919f36a049548e8d383d7834dab9ddfd1b096 Mon Sep 17 00:00:00 2001 From: Karim Fadel Date: Tue, 13 Jan 2026 23:56:15 +0200 Subject: [PATCH] create static names --- .../main/java/com/gildedrose/GildedRose.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/Java-Approvals/src/main/java/com/gildedrose/GildedRose.java b/Java-Approvals/src/main/java/com/gildedrose/GildedRose.java index 29f98593..a39c886f 100644 --- a/Java-Approvals/src/main/java/com/gildedrose/GildedRose.java +++ b/Java-Approvals/src/main/java/com/gildedrose/GildedRose.java @@ -1,6 +1,9 @@ package com.gildedrose; class GildedRose { + private static String AGED_BRIE = "Aged Brie"; + private static String BACKSTAGE_PASSES = "Backstage passes to a TAFKAL80ETC concert"; + private static String SULFURAS = "Sulfuras, Hand of Ragnaros"; Item[] items; public GildedRose(Item[] items) { @@ -9,12 +12,12 @@ class GildedRose { public void updateQuality() { for (int i = 0; i < items.length; i++) { - if (items[i].name.equals("Aged Brie") - || items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (items[i].name.equals(AGED_BRIE) + || items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].quality < 50) { items[i].quality = items[i].quality + 1; - if (items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].sellIn < 11) { if (items[i].quality < 50) { items[i].quality = items[i].quality + 1; @@ -30,21 +33,21 @@ class GildedRose { } } else { if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { + if (!items[i].name.equals(SULFURAS)) { items[i].quality = items[i].quality - 1; } } } - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { + if (!items[i].name.equals(SULFURAS)) { items[i].sellIn = items[i].sellIn - 1; } if (items[i].sellIn < 0) { - if (!items[i].name.equals("Aged Brie")) { - if (!items[i].name.equals("Backstage passes to a TAFKAL80ETC concert")) { + if (!items[i].name.equals(AGED_BRIE)) { + if (!items[i].name.equals(BACKSTAGE_PASSES)) { if (items[i].quality > 0) { - if (!items[i].name.equals("Sulfuras, Hand of Ragnaros")) { + if (!items[i].name.equals(SULFURAS)) { items[i].quality = items[i].quality - 1; } }