mirror of
https://github.com/emilybache/GildedRose-Refactoring-Kata.git
synced 2026-06-28 19:51:12 +00:00
python refactoring
This commit is contained in:
Artyom
parent
3e0085bfd0
commit
989d5442c5
@ -7,33 +7,49 @@ class GildedRose(object):
|
||||
|
||||
def update_quality(self):
|
||||
for item in self.items:
|
||||
if item.name != "Aged Brie" and item.name != "Backstage passes to a TAFKAL80ETC concert":
|
||||
if item.quality > 0:
|
||||
if item.name != "Sulfuras, Hand of Ragnaros":
|
||||
item.quality = item.quality - 1
|
||||
else:
|
||||
if item.quality < 50:
|
||||
item.quality = item.quality + 1
|
||||
if item.name == "Backstage passes to a TAFKAL80ETC concert":
|
||||
if item.sell_in < 11:
|
||||
if item.quality < 50:
|
||||
item.quality = item.quality + 1
|
||||
if item.sell_in < 6:
|
||||
if item.quality < 50:
|
||||
item.quality = item.quality + 1
|
||||
if item.name != "Sulfuras, Hand of Ragnaros":
|
||||
item.sell_in = item.sell_in - 1
|
||||
if item.sell_in < 0:
|
||||
if item.name != "Aged Brie":
|
||||
if item.name != "Backstage passes to a TAFKAL80ETC concert":
|
||||
if item.quality > 0:
|
||||
if item.name != "Sulfuras, Hand of Ragnaros":
|
||||
item.quality = item.quality - 1
|
||||
else:
|
||||
item.quality = item.quality - item.quality
|
||||
else:
|
||||
if item.quality < 50:
|
||||
item.quality = item.quality + 1
|
||||
self._update_item(item)
|
||||
|
||||
def _update_item(self, item):
|
||||
if item.name == "Aged Brie":
|
||||
self._update_aged_brie(item)
|
||||
elif item.name == "Backstage passes to a TAFKAL80ETC concert":
|
||||
self._update_backstage_pass(item)
|
||||
elif item.name == "Sulfuras, Hand of Ragnaros":
|
||||
return
|
||||
else:
|
||||
self._update_normal(item)
|
||||
|
||||
if item.name != "Sulfuras, Hand of Ragnaros":
|
||||
item.sell_in -= 1
|
||||
|
||||
if item.sell_in < 0:
|
||||
self._handle_expired(item)
|
||||
|
||||
def _update_normal(self, item):
|
||||
if item.quality > 0:
|
||||
item.quality -= 1
|
||||
|
||||
def _update_aged_brie(self, item):
|
||||
if item.quality < 50:
|
||||
item.quality += 1
|
||||
|
||||
def _update_backstage_pass(self, item):
|
||||
if item.quality < 50:
|
||||
item.quality += 1
|
||||
if item.sell_in < 11 and item.quality < 50:
|
||||
item.quality += 1
|
||||
if item.sell_in < 6 and item.quality < 50:
|
||||
item.quality += 1
|
||||
|
||||
def _handle_expired(self, item):
|
||||
if item.name == "Aged Brie":
|
||||
if item.quality < 50:
|
||||
item.quality += 1
|
||||
elif item.name == "Backstage passes to a TAFKAL80ETC concert":
|
||||
item.quality = 0
|
||||
elif item.name != "Sulfuras, Hand of Ragnaros":
|
||||
if item.quality > 0:
|
||||
item.quality -= 1
|
||||
|
||||
|
||||
class Item:
|
||||
|
||||
@ -5,11 +5,88 @@ from gilded_rose import Item, GildedRose
|
||||
|
||||
|
||||
class GildedRoseTest(unittest.TestCase):
|
||||
def test_foo(self):
|
||||
items = [Item("foo", 0, 0)]
|
||||
gilded_rose = GildedRose(items)
|
||||
gilded_rose.update_quality()
|
||||
self.assertEqual("fixme", items[0].name)
|
||||
def test_normal_item_before_sell_in(self):
|
||||
items = [Item("Normal", 5, 10)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 9)
|
||||
self.assertEqual(items[0].sell_in, 4)
|
||||
|
||||
def test_normal_item_after_sell_in(self):
|
||||
items = [Item("Normal", 0, 10)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 8)
|
||||
self.assertEqual(items[0].sell_in, -1)
|
||||
|
||||
def test_aged_brie_increases_quality(self):
|
||||
items = [Item("Aged Brie", 2, 0)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 1)
|
||||
self.assertEqual(items[0].sell_in, 1)
|
||||
|
||||
def test_aged_brie_never_exceeds_50(self):
|
||||
items = [Item("Aged Brie", 2, 50)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 50)
|
||||
self.assertEqual(items[0].sell_in, 1)
|
||||
|
||||
def test_backstage_passes_increases_by_1_when_sell_in_more_than_10(self):
|
||||
items = [Item("Backstage passes to a TAFKAL80ETC concert", 15, 20)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 21)
|
||||
self.assertEqual(items[0].sell_in, 14)
|
||||
|
||||
def test_backstage_passes_increases_by_2_when_sell_in_10_or_less(self):
|
||||
items = [Item("Backstage passes to a TAFKAL80ETC concert", 10, 20)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 22)
|
||||
self.assertEqual(items[0].sell_in, 9)
|
||||
|
||||
def test_backstage_passes_increases_by_3_when_sell_in_5_or_less(self):
|
||||
items = [Item("Backstage passes to a TAFKAL80ETC concert", 5, 20)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 23)
|
||||
self.assertEqual(items[0].sell_in, 4)
|
||||
|
||||
def test_backstage_passes_quality_drops_to_zero_after_concert(self):
|
||||
items = [Item("Backstage passes to a TAFKAL80ETC concert", 0, 20)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 0)
|
||||
self.assertEqual(items[0].sell_in, -1)
|
||||
|
||||
def test_sulfuras_never_changes(self):
|
||||
items = [Item("Sulfuras, Hand of Ragnaros", 0, 80)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 80)
|
||||
self.assertEqual(items[0].sell_in, 0)
|
||||
|
||||
def test_sulfuras_with_positive_sell_in_also_unchanged(self):
|
||||
items = [Item("Sulfuras, Hand of Ragnaros", 5, 80)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 80)
|
||||
self.assertEqual(items[0].sell_in, 5)
|
||||
|
||||
def test_quality_never_negative(self):
|
||||
items = [Item("Normal", 0, 0)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 0)
|
||||
|
||||
def test_conjured_items_are_not_supported_yet_but_work_as_normal(self):
|
||||
items = [Item("Conjured Mana Cake", 3, 6)]
|
||||
gilded = GildedRose(items)
|
||||
gilded.update_quality()
|
||||
self.assertEqual(items[0].quality, 5)
|
||||
self.assertEqual(items[0].sell_in, 2)
|
||||
|
||||
|
||||
if __name__ == '__main__':
|
||||
|
||||
Loading…
Reference in New Issue
Block a user