OpenSource/GildedRose-Refactoring-Kata
1
0
Fork 0
mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-02-21 09:21:08 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

added 5 & 10 day tests

Browse Source
This commit is contained in:
david.wolfson 2024-10-07 15:25:58 +01:00
parent 12390fd02f
commit b236c1e9f4
3 changed files with 134 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
go/bug.md Normal file
View File

@ -0,0 +1,43 @@
# A list of observed potential bugs to investigate
## Conjured Items
"We have recently signed a supplier of conjured items. This requires an update to our system:
"Conjured" items degrade in Quality twice as fast as normal items"
```
>go run texttest_fixture.go 5
...
-------- day 0 --------
Name, SellIn, Quality
...
&{Conjured Mana Cake 3 6}
...
-------- day 1 --------
&{Conjured Mana Cake 2 5}
...
-------- day 2 --------
&{Conjured Mana Cake 1 4}
...
-------- day 3 --------
&{Conjured Mana Cake 0 3}
...
-------- day 4 --------
&{Conjured Mana Cake -1 1}
...
-------- day 5 --------
&{Conjured Mana Cake -2 0}
```
Appears that Qaulity jumps by 2 on data 4 (i.e. quality is never 2)
## aged brie
"Once the sell by date has passed, Quality degrades twice as fast"
"Aged Brie" actually increases in Quality the older it gets
initial behaviour is that quality increases twice as fast after SellIn

90
go/gildedrose/gildedrose_test.go
View File

@ -41,7 +41,7 @@ func Test_oneDay(t *testing.T) {
{"Backstage passes to a TAFKAL80ETC concert", 15, 20},
{"Backstage passes to a TAFKAL80ETC concert", 10, 49},
{"Backstage passes to a TAFKAL80ETC concert", 5, 49},
{"Conjured Mana Cake", 3, 6}, // <-- :O
{"Conjured Mana Cake", 3, 6},
}
var expected = []*gildedrose.Item{
@ -73,3 +73,91 @@ func Test_oneDay(t *testing.T) {
}
}
func Test_twoDays(t *testing.T) {
// Arrange
var items = []*gildedrose.Item{
{"+5 Dexterity Vest", 10, 20},
{"Aged Brie", 2, 0},
{"Elixir of the Mongoose", 5, 7},
{"Sulfuras, Hand of Ragnaros", 0, 80},
{"Sulfuras, Hand of Ragnaros", -1, 80},
{"Backstage passes to a TAFKAL80ETC concert", 15, 20},
{"Backstage passes to a TAFKAL80ETC concert", 10, 49},
{"Backstage passes to a TAFKAL80ETC concert", 5, 49},
{"Conjured Mana Cake", 3, 6},
}
var expected = []*gildedrose.Item{
{"+5 Dexterity Vest", 8, 18},
{"Aged Brie", 0, 2},
{"Elixir of the Mongoose", 3, 5},
{"Sulfuras, Hand of Ragnaros", 0, 80},
{"Sulfuras, Hand of Ragnaros", -1, 80},
{"Backstage passes to a TAFKAL80ETC concert", 13, 22},
{"Backstage passes to a TAFKAL80ETC concert", 8, 50},
{"Backstage passes to a TAFKAL80ETC concert", 3, 50},
{"Conjured Mana Cake", 1, 4}, // <-- :O
}
// Act
gildedrose.UpdateQuality(items)
gildedrose.UpdateQuality(items)
// Assert
for i, item := range expected {
if items[i].Name != item.Name {
t.Errorf("Name: Expected %s but got %s ", item.Name, items[i].Name)
}
if items[i].SellIn != item.SellIn {
t.Errorf("%s - SellIn: Expected %d but got %d ", item.Name, item.SellIn, items[i].SellIn)
}
if items[i].Quality != item.Quality {
t.Errorf("%s - Quality: Expected %d but got %d ", item.Name, item.Quality, items[i].Quality)
}
}
}
func Test_fiveDays(t *testing.T) {
// Arrange
var items = []*gildedrose.Item{
{"+5 Dexterity Vest", 10, 20},
{"Aged Brie", 2, 0},
{"Elixir of the Mongoose", 5, 7},
{"Sulfuras, Hand of Ragnaros", 0, 80},
{"Sulfuras, Hand of Ragnaros", -1, 80},
{"Backstage passes to a TAFKAL80ETC concert", 15, 20},
{"Backstage passes to a TAFKAL80ETC concert", 10, 49},
{"Backstage passes to a TAFKAL80ETC concert", 5, 49},
{"Conjured Mana Cake", 3, 6},
}
var expected = []*gildedrose.Item{
{"+5 Dexterity Vest", 0, 10},
{"Aged Brie", -8, 18},
{"Elixir of the Mongoose", -5, 0},
{"Sulfuras, Hand of Ragnaros", 0, 80},
{"Sulfuras, Hand of Ragnaros", -1, 80},
{"Backstage passes to a TAFKAL80ETC concert", 5, 35},
{"Backstage passes to a TAFKAL80ETC concert", 0, 50},
{"Backstage passes to a TAFKAL80ETC concert", -5, 0},
{"Conjured Mana Cake", -7, 0}, // <-- :O
}
// Act
for day := 1; day <= 10; day++ {
gildedrose.UpdateQuality(items)
}
// Assert
for i, item := range expected {
if items[i].Name != item.Name {
t.Errorf("Name: Expected %s but got %s ", item.Name, items[i].Name)
}
if items[i].SellIn != item.SellIn {
t.Errorf("%s - SellIn: Expected %d but got %d ", item.Name, item.SellIn, items[i].SellIn)
}
if items[i].Quality != item.Quality {
t.Errorf("%s - Quality: Expected %d but got %d ", item.Name, item.Quality, items[i].Quality)
}
}
}

4
go/texttest_fixture.go
View File

@ -12,8 +12,8 @@ func main() {
fmt.Println("OMGHAI!")
var items = []*gildedrose.Item{
{Name: "+5 Dexterity Vest", SellIn: 10, Quality: 20},
{Name: "Aged Brie", SellIn: 2, Quality: 0},
{"+5 Dexterity Vest", 10, 20},
{"Aged Brie", 2, 0},
{"Elixir of the Mongoose", 5, 7},
{"Sulfuras, Hand of Ragnaros", 0, 80},
{"Sulfuras, Hand of Ragnaros", -1, 80},