From e43a1a270f3da711669e679ef7085f8e6ff4c651 Mon Sep 17 00:00:00 2001 From: Peter Kofler Date: Wed, 17 Jan 2024 20:12:19 +0100 Subject: [PATCH] Replace complete tests with sample tests. --- ruby/gilded_rose_spec.rb | 76 +++------------------------------------ ruby/gilded_rose_tests.rb | 66 +++------------------------------- 2 files changed, 8 insertions(+), 134 deletions(-) diff --git a/ruby/gilded_rose_spec.rb b/ruby/gilded_rose_spec.rb index 1ad468f8..015a759f 100644 --- a/ruby/gilded_rose_spec.rb +++ b/ruby/gilded_rose_spec.rb @@ -3,77 +3,9 @@ require 'rspec' require File.join(File.dirname(__FILE__), 'gilded_rose') describe GildedRose do - - describe "#update_quality" do - it "does not change the name" do - items = [Item.new("foo", 0, 0)] - GildedRose.new(items).update_quality() - expect(items[0].name).to eq "foo" - end - - it 'decreases the sell_in and quality for regular items' do - item = Item.new('Regular Item', 5, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(9) - expect(item.sell_in).to eq(4) - end - - it 'decreases quality twice as fast when sell_in is negative for regular items' do - item = Item.new('Regular Item', 0, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(8) - end - - it 'increases the quality of Aged Brie' do - item = Item.new('Aged Brie', 5, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(11) - end - - it 'does not increase the quality of Aged Brie beyond 50' do - item = Item.new('Aged Brie', 5, 50) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(50) - end - - it 'increases the quality of Backstage passes as sell_in approaches' do - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 11, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(21) - end - - it 'increases the quality of Backstage passes by 2 when sell_in is 10 or less' do - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 10, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(22) - end - - it 'increases the quality of Backstage passes by 3 when sell_in is 5 or less' do - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 5, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(23) - end - - it 'sets the quality of Backstage passes to 0 after the concert' do - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 0, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(0) - end - - it 'does not decrease the quality of Sulfuras' do - item = Item.new('Sulfuras, Hand of Ragnaros', 5, 80) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - expect(item.quality).to eq(80) - end + it "does not change the name" do + items = [Item.new("foo", 0, 0)] + GildedRose.new(items).update_quality() + expect(items[0].name).to eq "fixme" end - end diff --git a/ruby/gilded_rose_tests.rb b/ruby/gilded_rose_tests.rb index b7643d3e..4e2ec30d 100644 --- a/ruby/gilded_rose_tests.rb +++ b/ruby/gilded_rose_tests.rb @@ -2,67 +2,9 @@ require 'minitest/autorun' require_relative 'gilded_rose' class TestGildedRose < Minitest::Test - def test_update_quality_regular_item - item = Item.new('Regular Item', 5, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 9, item.quality - assert_equal 4, item.sell_in - end - - def test_update_quality_negative_sell_in_regular_item - item = Item.new('Regular Item', 0, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 8, item.quality - end - - def test_update_quality_aged_brie - item = Item.new('Aged Brie', 5, 10) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 11, item.quality - end - - def test_update_quality_max_quality_aged_brie - item = Item.new('Aged Brie', 5, 50) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 50, item.quality - end - - def test_update_quality_backstage_passes_approaching - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 11, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 21, item.quality - end - - def test_update_quality_backstage_passes_sell_in_10_or_less - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 10, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 22, item.quality - end - - def test_update_quality_backstage_passes_sell_in_5_or_less - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 5, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 23, item.quality - end - - def test_update_quality_backstage_passes_after_concert - item = Item.new('Backstage passes to a TAFKAL80ETC concert', 0, 20) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 0, item.quality - end - - def test_update_quality_sulfuras - item = Item.new('Sulfuras, Hand of Ragnaros', 5, 80) - gilded_rose = GildedRose.new([item]) - gilded_rose.update_quality - assert_equal 80, item.quality + def test_foo + items = [Item.new("foo", 0, 0)] + GildedRose.new(items).update_quality() + assert_equal "fixme", items[0].name end end