GildedRose-Refactoring-Kata

OpenSource/GildedRose-Refactoring-Kata

Fork 0

mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-05-21 01:01:19 +00:00

Commit Graph

Select branches

Hide Pull Requests

main

#1

#100

#101

#102

#103

#104

#105

#106

#107

#109

#11

#110

#111

#112

#113

#114

#115

#117

#118

#12

#120

#121

#122

#123

#124

#126

#127

#128

#129

#13

#130

#131

#132

#133

#134

#135

#136

#137

#138

#139

#14

#140

#141

#142

#143

#144

#145

#146

#147

#148

#149

#15

#150

#151

#152

#153

#154

#155

#156

#157

#159

#16

#160

#161

#162

#163

#164

#165

#166

#167

#168

#169

#17

#170

#171

#172

#173

#174

#176

#177

#178

#179

#18

#180

#181

#182

#183

#184

#185

#186

#187

#188

#189

#19

#190

#191

#192

#193

#194

#196

#197

#198

#199

#2

#20

#200

#201

#202

#203

#204

#205

#206

#207

#208

#209

#21

#210

#211

#212

#214

#215

#216

#217

#218

#219

#22

#22

#220

#221

#222

#223

#224

#225

#226

#227

#228

#229

#23

#230

#231

#232

#233

#234

#235

#236

#237

#238

#239

#24

#24

#240

#241

#242

#243

#244

#245

#246

#247

#248

#249

#25

#25

#250

#251

#252

#253

#254

#255

#256

#257

#258

#259

#26

#260

#261

#262

#264

#265

#266

#267

#268

#27

#270

#271

#272

#273

#274

#275

#276

#277

#278

#279

#28

#280

#281

#282

#283

#284

#285

#286

#287

#288

#289

#29

#290

#291

#292

#293

#294

#295

#296

#297

#298

#299

#3

#30

#30

#300

#301

#302

#303

#304

#305

#306

#307

#308

#309

#31

#310

#311

#313

#314

#315

#316

#317

#318

#319

#320

#321

#322

#323

#324

#325

#326

#327

#328

#329

#33

#330

#331

#332

#333

#334

#335

#336

#337

#338

#339

#340

#341

#342

#343

#344

#345

#346

#347

#348

#349

#35

#350

#351

#352

#353

#354

#355

#356

#357

#358

#36

#361

#362

#363

#364

#365

#366

#367

#368

#369

#37

#370

#371

#372

#373

#374

#375

#376

#377

#378

#379

#38

#38

#380

#381

#382

#383

#384

#385

#386

#387

#388

#389

#39

#39

#390

#391

#392

#393

#394

#395

#396

#397

#399

#4

#40

#400

#401

#402

#403

#404

#405

#406

#407

#409

#41

#410

#411

#412

#413

#414

#415

#416

#417

#418

#419

#42

#420

#421

#422

#423

#424

#425

#426

#427

#428

#429

#430

#431

#432

#433

#434

#435

#436

#437

#438

#439

#44

#440

#441

#442

#443

#445

#446

#447

#448

#449

#450

#451

#451

#452

#453

#454

#455

#456

#457

#458

#459

#46

#460

#461

#462

#463

#464

#466

#467

#468

#469

#47

#470

#471

#473

#474

#475

#476

#477

#478

#479

#48

#480

#481

#482

#483

#484

#485

#486

#487

#488

#489

#49

#490

#491

#492

#493

#495

#496

#497

#498

#499

#5

#50

#500

#501

#502

#503

#504

#505

#506

#508

#509

#51

#510

#511

#512

#513

#514

#515

#516

#517

#518

#519

#52

#520

#521

#522

#523

#524

#525

#527

#528

#529

#53

#53

#530

#531

#532

#533

#534

#535

#536

#537

#538

#539

#54

#540

#542

#543

#544

#545

#546

#547

#548

#549

#55

#550

#551

#552

#553

#554

#555

#556

#557

#558

#559

#56

#560

#562

#563

#564

#565

#566

#567

#568

#569

#57

#57

#570

#571

#572

#573

#574

#575

#576

#577

#578

#58

#580

#581

#582

#583

#584

#585

#586

#587

#588

#589

#59

#590

#591

#594

#595

#596

#597

#598

#599

#6

#60

#600

#601

#602

#603

#604

#605

#606

#607

#608

#608

#609

#609

#61

#610

#611

#612

#613

#614

#615

#616

#617

#618

#619

#62

#620

#621

#622

#623

#624

#625

#626

#627

#628

#629

#63

#630

#631

#632

#633

#634

#635

#636

#637

#638

#639

#64

#640

#641

#642

#643

#643

#645

#646

#647

#648

#649

#65

#65

#650

#651

#652

#653

#654

#655

#656

#657

#658

#659

#66

#66

#660

#661

#662

#663

#664

#665

#666

#667

#668

#669

#67

#67

#670

#671

#672

#673

#674

#675

#676

#677

#677

#678

#679

#68

#680

#681

#682

#683

#684

#685

#686

#687

#688

#689

#69

#690

#691

#692

#693

#694

#695

#696

#697

#698

#699

#7

#7

#70

#700

#71

#71

#72

#72

#73

#73

#74

#74

#75

#76

#77

#77

#78

#78

#79

#79

#8

#80

#81

#82

#82

#83

#84

#85

#85

#86

#87

#88

#88

#89

#9

#90

#91

#92

#92

#93

#94

#95

#95

#96

#97

#98

#99

4639d18db0 Add test: decreases quality by 1 Dan Holmes 2020-12-03 13:33:57 +0000
e72f1de3af Add test: decreases sellIn by 1 Dan Holmes 2020-12-03 12:25:05 +0000
75ef572dfa Refactor test descriptions Dan Holmes 2020-12-03 12:04:34 +0000
126208a692 Change file name for shop class Dan Holmes 2020-12-03 12:02:27 +0000
f9f3bb2187 Seperate item class to seperate file Dan Holmes 2020-12-03 12:00:41 +0000
51316a82c5 Mock item Dan Holmes 2020-12-03 12:00:23 +0000
92b6f1df15 Fix and pass first test Dan Holmes 2020-12-03 11:52:38 +0000
2f4fd5f3fe Added rules for conjured items Lucas van Dongen 2020-11-23 17:31:19 +0100
4e79a86e03 Added sell-in modification rules Lucas van Dongen 2020-11-23 17:31:04 +0100
44bc9f5718 Added check on Brie always getting better Lucas van Dongen 2020-11-23 17:05:53 +0100
8f15db659d Replaced all quality modification rules with a new enum rule based on a protocol Lucas van Dongen 2020-11-23 17:05:35 +0100
6323c90d96 Added Conjured tests, 2 fail 1 passes Lucas van Dongen 2020-11-23 15:16:14 +0100
95946cf453 Added extension to to make it easier to test updates to quality Lucas van Dongen 2020-11-23 15:15:44 +0100
d5c6b9f9ce Added advanced rules Lucas van Dongen 2020-11-23 14:51:14 +0100
6dcf0c233e Deleted unused example test Lucas van Dongen 2020-11-23 14:51:06 +0100
e1e1abeadf Added base rules Lucas van Dongen 2020-11-23 14:04:33 +0100
ef2d3a6f91 Added the Package to my test project Lucas van Dongen 2020-11-23 13:50:00 +0100
a95750265b Fix ruby version Chris "The Chris" Iriondo 2020-11-11 15:17:54 -0700
7ce807b1cd make better zdenkers 2020-11-11 15:10:25 -0700
f8ce1c6e9b put expected last as is proper zdenkers 2020-11-11 15:09:47 -0700
0f2437eeeb Merge branch 'master' of github.com:3-form/GildedRose-Refactoring-Kata Jayce Pulsipher 2020-11-11 13:25:46 -0700
9374d46a35 Setup JS Jayce Pulsipher 2020-11-11 13:24:58 -0700
8bf91ebe59 fix test to pass when criteria met zdenkers 2020-11-11 13:23:50 -0700
8800aedc83 include fixture update fixture compare on fixture and init with better values zdenkers 2020-11-11 12:56:34 -0700
f7f0529960 reduce duplication and minimal improve elieser pereira 2020-11-10 22:23:06 -0300
a07bfdf852 tests and conjured items, friday elieser pereira 2020-11-06 18:13:44 -0300
d77106e636 add couple more tests to improve coverage dreddick.home2@gmail.com 2020-11-06 09:32:53 +0000
e44b8e2510 remove texttest_fixture.go dreddick.home2@gmail.com 2020-11-06 09:32:30 +0000
ceda8ff096 add comments dreddick.home2@gmail.com 2020-11-05 19:44:41 +0000
c74abe5e3c extracted feature tests to their own files ollie beney 2020-11-05 17:34:00 +0000
c63614cc15 add comments dreddick.home2@gmail.com 2020-11-05 17:26:20 +0000
0d24f3ed98 update tests and code for new conjured requirements dreddick.home2@gmail.com 2020-11-05 17:09:54 +0000
75fa4869c0 found and fixed bug where quality could go above 50 and below 0 when change increment was greater than one ollie beney 2020-11-05 17:03:15 +0000
080b998176 refactor UpdateQuality into switch statement dreddick.home2@gmail.com 2020-11-05 17:03:04 +0000
124578588e add standard quality update function dreddick.home2@gmail.com 2020-11-05 16:52:22 +0000
6de0629b44 add backstage pass separate update func dreddick.home2@gmail.com 2020-11-05 16:44:36 +0000
6a651a5f7a add min function dreddick.home2@gmail.com 2020-11-05 16:41:13 +0000
afa3d43717 separate brie update dreddick.home2@gmail.com 2020-11-05 16:31:48 +0000
24ebe0b7dd created boolean methods for brie and backstage, implemented them in a case statement ollie beney 2020-11-05 16:24:53 +0000
e2673f0734 extracted all product types into their own methods and tested ollie beney 2020-11-05 16:14:49 +0000
3d90e599d7 add tests for items dreddick.home2@gmail.com 2020-11-05 15:35:13 +0000
c0ae6e9988 extracted quality updates for backstage passes ollie beney 2020-11-05 15:16:09 +0000
146f686d14 removed duplicated conditionals ollie beney 2020-11-05 14:14:54 +0000
3773a972aa actually fixed special item this time, feature tests also fixed ollie beney 2020-11-05 12:49:20 +0000
89fb0d8689 corrected special_item method and added further test for this. ollie beney 2020-11-05 12:38:18 +0000
58be55719a extracted #special_item? method and implemented in update quality section ollie beney 2020-11-05 12:30:32 +0000
7a8792f64f got taken on to zoom call with peer group, unsure whats changed but rspec still passes ollie beney 2020-11-04 18:02:22 +0000
6c85b130e5 changed if statement to inline conditional ollie beney 2020-11-04 17:10:04 +0000
0ae0723f57 changed part of method that changes backstage pass quality to zero to a more logical method ollie beney 2020-11-04 17:07:04 +0000
626eab9e10 updated code to use update_normal_quality method ollie beney 2020-11-04 16:58:25 +0000
2431b8b11e replaced instances of item != sulfuras with sulfuras? method ollie beney 2020-11-04 16:57:36 +0000
70040c5144 updated spelling of sulfuras ollie beney 2020-11-04 16:55:20 +0000
bbe5395911 added method to check if an item is selfarus ollie beney 2020-11-04 16:51:20 +0000
27860ced34 update_normal_item method updates items without quality allowances if quality > 0 ollie beney 2020-11-04 16:39:36 +0000
2b410aa50b refactor backstage path to use regex, this allows other backstage items to work provided backstage is in their name ollie beney 2020-11-04 15:28:47 +0000
c940184607 add tests for backstage items ollie beney 2020-11-04 15:15:36 +0000
f7556aecc0 add tests for sulfuras input ollie beney 2020-11-04 15:04:25 +0000
39ff5fee08 test existing behaviour for aged brie ollie beney 2020-11-04 14:57:13 +0000
d8426bd884 testing to see if item value drops below 0 ollie beney 2020-11-04 14:36:00 +0000
fb4d5aad4d basic test for ordinary item, made update_quality method into an instance method ollie beney 2020-11-04 14:32:23 +0000
06c28be5b1 added rubocop ollie beney 2020-11-04 13:56:42 +0000
5437b449e8 removed files I'm not using ollie beney 2020-11-04 13:43:50 +0000
f2ffd56269 Finished tests Benjamin Barreto 2020-10-22 11:51:01 +0200
cd6ad78810 Finished AgedCheese tests Benjamin Barreto 2020-10-22 09:54:35 +0200
d1907e56a8 Added more comments and dock blocks Benjamin Barreto 2020-10-22 08:40:20 +0200
4520c75f4c Implemented conjured items Benjamin Barreto 2020-10-22 08:26:54 +0200
0abd370fd1 Implemented ConcertPass, AgedCheese, and LegendaryItem, along with better test output Benjamin Barreto 2020-10-21 21:11:27 +0200
278e67ae75 Added babel-node Benjamin Barreto 2020-10-21 18:06:58 +0200
fe72eddab1 Implemented RegularItem.updateQuality and tests Benjamin Barreto 2020-10-21 17:56:53 +0200
5367b03ff5 Missing logic dissection Benjamin Barreto 2020-10-21 16:21:27 +0200
79844c8a50 Dissected original logic, tested private variables, fixed stardjs linting Benjamin Barreto 2020-10-21 16:20:22 +0200
b2954e27ff Added RegularItem with tests Benjamin Barreto 2020-10-21 15:10:21 +0200
9cbeedd736 Added starndjs for linting, resolved initial errors, tested inheritance approach to tackle constraint of not touching the Item class Benjamin Barreto 2020-10-21 13:42:37 +0200
0c61f88ffc

Used consistant calling syntax in tests Kieran 2020-10-16 19:12:05 +0800
908055ba3e

Gilded rose in Nim Kieran 2020-10-16 18:59:43 +0800
3ce3aa316f fix code smells Santiago Garcia 2020-09-29 18:04:25 -0500
67769ddd57 fix code smells Santiago Garcia 2020-09-29 17:55:12 -0500
727d4b66c4 fix code smells Santiago Garcia 2020-09-29 17:52:44 -0500
724ab70dd6 Add new use case conjured items Refactor Method updateQuality Santiago Garcia 2020-09-29 17:47:03 -0500
915afb12db Fix Unit Test Santiago Garcia 2020-09-29 16:35:23 -0500
e2c5826e71

Merge pull request #184 from ag4ta/change-line-separator Emily Bache 2020-09-27 08:50:29 +0200
d68387dc6b Refactored to extract common code Added standard item to cucumber features Xavier Levaux 2020-09-26 11:23:28 +0200
3792d69022 Implemented quality update for "Conjured" item with Cucumber tests Xavier Levaux 2020-09-26 10:48:54 +0200
50daf3f025 Change line separator from CRLF to LF Agata Werszler 2020-09-25 16:30:58 +0200
5f8918b3f0 Refactored quality update using strategy and factory patterns Xavier Levaux 2020-09-25 09:15:45 +0200
5ed37f4be5

Merge pull request #182 from mebusw/patch-2 Emily Bache 2020-09-25 08:33:11 +0200
b713f7370d

Update GildedRoseRequirements_zh.txt Jacky Shen 2020-09-25 13:05:39 +0800
2a60407d6b Added tests to ensure no regression is introduced during refactoring Xavier Levaux 2020-09-24 17:02:46 +0200
936527e4d3 Test for Conjured items passed. Atul Anand 2020-09-14 01:19:06 +0530
559ac9fb91 Failing test for Conjured items. Atul Anand 2020-09-14 01:15:19 +0530
c29949a491 Refactored GildedRose Atul Anand 2020-09-14 01:04:08 +0530
5f9bbe6716 Integration tests Atul Anand 2020-09-14 00:58:30 +0530
bc2126c1c5 Fixed Conjoured items Audrius Baltusis 2020-09-08 21:26:45 +0300
eac154af0b Refactored shop... Wait, everything was deleted and started from scratch Audrius Baltusis 2020-09-08 21:25:42 +0300
3ad64a7065 Updated names and labels Audrius Baltusis 2020-09-08 18:09:43 +0300
748b1a0313 Make tests great again Audrius Baltusis 2020-09-08 18:02:37 +0300
a8dd468300

Merge pull request #179 from emilybache/dependabot/composer/php/symfony/http-kernel-5.1.5 Emily Bache 2020-09-08 14:51:16 +0000
b4a6bc2445

Merge pull request #178 from emilybache/dependabot/npm_and_yarn/js-jest/yargs-parser-13.1.2 Emily Bache 2020-09-08 14:47:05 +0000
9c42d32cf4

Bump symfony/http-kernel from 5.0.8 to 5.1.5 in /php dependabot[bot] 2020-09-08 13:27:13 +0000
e5d807ebeb

Bump yargs-parser from 13.1.1 to 13.1.2 in /js-jest dependabot[bot] 2020-09-08 13:26:39 +0000