GildedRose-Refactoring-Kata

OpenSource/GildedRose-Refactoring-Kata

Fork 0

mirror of https://github.com/emilybache/GildedRose-Refactoring-Kata.git synced 2026-05-20 16:51:24 +00:00

Commit Graph

Select branches

Hide Pull Requests

main

#1

#100

#101

#102

#103

#104

#105

#106

#107

#109

#11

#110

#111

#112

#113

#114

#115

#117

#118

#12

#120

#121

#122

#123

#124

#126

#127

#128

#129

#13

#130

#131

#132

#133

#134

#135

#136

#137

#138

#139

#14

#140

#141

#142

#143

#144

#145

#146

#147

#148

#149

#15

#150

#151

#152

#153

#154

#155

#156

#157

#159

#16

#160

#161

#162

#163

#164

#165

#166

#167

#168

#169

#17

#170

#171

#172

#173

#174

#176

#177

#178

#179

#18

#180

#181

#182

#183

#184

#185

#186

#187

#188

#189

#19

#190

#191

#192

#193

#194

#196

#197

#198

#199

#2

#20

#200

#201

#202

#203

#204

#205

#206

#207

#208

#209

#21

#210

#211

#212

#214

#215

#216

#217

#218

#219

#22

#22

#220

#221

#222

#223

#224

#225

#226

#227

#228

#229

#23

#230

#231

#232

#233

#234

#235

#236

#237

#238

#239

#24

#24

#240

#241

#242

#243

#244

#245

#246

#247

#248

#249

#25

#25

#250

#251

#252

#253

#254

#255

#256

#257

#258

#259

#26

#260

#261

#262

#264

#265

#266

#267

#268

#27

#270

#271

#272

#273

#274

#275

#276

#277

#278

#279

#28

#280

#281

#282

#283

#284

#285

#286

#287

#288

#289

#29

#290

#291

#292

#293

#294

#295

#296

#297

#298

#299

#3

#30

#30

#300

#301

#302

#303

#304

#305

#306

#307

#308

#309

#31

#310

#311

#313

#314

#315

#316

#317

#318

#319

#320

#321

#322

#323

#324

#325

#326

#327

#328

#329

#33

#330

#331

#332

#333

#334

#335

#336

#337

#338

#339

#340

#341

#342

#343

#344

#345

#346

#347

#348

#349

#35

#350

#351

#352

#353

#354

#355

#356

#357

#358

#36

#361

#362

#363

#364

#365

#366

#367

#368

#369

#37

#370

#371

#372

#373

#374

#375

#376

#377

#378

#379

#38

#38

#380

#381

#382

#383

#384

#385

#386

#387

#388

#389

#39

#39

#390

#391

#392

#393

#394

#395

#396

#397

#399

#4

#40

#400

#401

#402

#403

#404

#405

#406

#407

#409

#41

#410

#411

#412

#413

#414

#415

#416

#417

#418

#419

#42

#420

#421

#422

#423

#424

#425

#426

#427

#428

#429

#430

#431

#432

#433

#434

#435

#436

#437

#438

#439

#44

#440

#441

#442

#443

#445

#446

#447

#448

#449

#450

#451

#451

#452

#453

#454

#455

#456

#457

#458

#459

#46

#460

#461

#462

#463

#464

#466

#467

#468

#469

#47

#470

#471

#473

#474

#475

#476

#477

#478

#479

#48

#480

#481

#482

#483

#484

#485

#486

#487

#488

#489

#49

#490

#491

#492

#493

#495

#496

#497

#498

#499

#5

#50

#500

#501

#502

#503

#504

#505

#506

#508

#509

#51

#510

#511

#512

#513

#514

#515

#516

#517

#518

#519

#52

#520

#521

#522

#523

#524

#525

#527

#528

#529

#53

#53

#530

#531

#532

#533

#534

#535

#536

#537

#538

#539

#54

#540

#542

#543

#544

#545

#546

#547

#548

#549

#55

#550

#551

#552

#553

#554

#555

#556

#557

#558

#559

#56

#560

#562

#563

#564

#565

#566

#567

#568

#569

#57

#57

#570

#571

#572

#573

#574

#575

#576

#577

#578

#58

#580

#581

#582

#583

#584

#585

#586

#587

#588

#589

#59

#590

#591

#594

#595

#596

#597

#598

#599

#6

#60

#600

#601

#602

#603

#604

#605

#606

#607

#608

#608

#609

#609

#61

#610

#611

#612

#613

#614

#615

#616

#617

#618

#619

#62

#620

#621

#622

#623

#624

#625

#626

#627

#628

#629

#63

#630

#631

#632

#633

#634

#635

#636

#637

#638

#639

#64

#640

#641

#642

#643

#643

#645

#646

#647

#648

#649

#65

#65

#650

#651

#652

#653

#654

#655

#656

#657

#658

#659

#66

#66

#660

#661

#662

#663

#664

#665

#666

#667

#668

#669

#67

#67

#670

#671

#672

#673

#674

#675

#676

#677

#677

#678

#679

#68

#680

#681

#682

#683

#684

#685

#686

#687

#688

#689

#69

#690

#691

#692

#693

#694

#695

#696

#697

#698

#699

#7

#7

#70

#700

#71

#71

#72

#72

#73

#73

#74

#74

#75

#76

#77

#77

#78

#78

#79

#79

#8

#80

#81

#82

#82

#83

#84

#85

#85

#86

#87

#88

#88

#89

#9

#90

#91

#92

#92

#93

#94

#95

#95

#96

#97

#98

#99

99703481d7

Merge pull request #177 from emilybache/dependabot/npm_and_yarn/js-jest/handlebars-4.7.6 Emily Bache 2020-09-08 11:34:41 +0000
8140c13575

Bump handlebars from 4.4.3 to 4.7.6 in /js-jest dependabot[bot] 2020-09-07 14:24:39 +0000
1c94a43a2d

Merge pull request #176 from olivierperez/fix/adjust-fr-requirements Emily Bache 2020-09-07 13:46:10 +0000
e5c0d2653c Adjust a bit French description Olivier PEREZ 2020-09-06 15:40:23 +0200
94b6e7a1e8

Merge pull request #174 from wpanas/upgrade_kotlin Emily Bache 2020-08-21 11:12:02 +0000
cce7b6381f Upgrade kotlin to 1.4.0, junit to 5.6.2 & gradle to 6.6 wpanas 2020-08-20 14:44:45 +0200
e55dae2ce7 - Adding code comments - Removing blank spaces Manali Mogre 2020-08-19 13:59:09 +0200
476116d783

Merge pull request #1 from ManaliSingh27/dev Manali Mogre 2020-08-19 13:50:35 +0200
9a4efc2c98 - Grouping the files Manali Mogre 2020-08-19 13:44:54 +0200
2738713929 - Updating Code Comments - Updating variable names Manali Mogre 2020-08-18 22:49:14 +0200
71459293bb Adding Conjured Item Manali Mogre 2020-08-18 21:34:07 +0200
e9541d42b8 Changing static function to class function to allow method overriding Manali Mogre 2020-08-18 21:32:37 +0200
576ecc136d - Moving Test Cases for Items in separate files Manali Mogre 2020-08-17 23:08:28 +0200
892c869e2f Adding Test cases for Conjured Items Manali Mogre 2020-08-17 22:59:11 +0200
5e32a34b84 - Code Refactoring : Adding function declarations in protocol Manali Mogre 2020-08-17 22:49:38 +0200
08c1415e17 - Code refactoring as per SOLID Principles Manali Mogre 2020-08-17 22:38:57 +0200
bf62bf2ceb - Creating a Protocol for Factory Method Manali Mogre 2020-08-17 20:49:39 +0200
db0db19d5d - Code Refactoring Manali Mogre 2020-08-17 20:14:47 +0200
d363612674 - Code Refactoring Manali Mogre 2020-08-17 13:26:05 +0200
cd4e977616

Merge pull request #171 from nihonbuson/master Emily Bache 2020-08-17 05:50:10 +0000
64149da564 調整GildedRose.updateQuality()和test case liaolizhen 2020-08-17 10:09:07 +0800
30d1966bbe

Update GildedRoseRequirements_jp.md nihonbuson 2020-08-17 10:47:34 +0900
936c96524b

Create GildedRoseRequirements_jp.md nihonbuson 2020-08-17 10:46:24 +0900
56c16eaa70 修改Item且增加4支subclass liaolizhen 2020-08-17 09:44:10 +0800
b2b61a1f57 - Updated Naming Conventions Manali Mogre 2020-08-16 21:04:26 +0200
5bec9bdff4 - Code Foramtting Manali Mogre 2020-08-16 20:46:04 +0200
d84a836ca6 - Code Refactoring : Adding code for Custom Items Manali Mogre 2020-08-16 18:03:19 +0200
f19d8141a4 - Creating separate files for different Items Manali Mogre 2020-08-16 14:25:03 +0200
0830292975 - Adding Constants for Item Names - Refactoring Code with Switch cases Manali Mogre 2020-08-16 14:13:53 +0200
3cdbf4bc87 - Adding Test cases for existing code Manali Mogre 2020-08-15 23:42:40 +0200
43c9b0db33 Refactor method for Quality decrease, increase jiajun.chou 2020-08-13 22:09:45 +0800
7115cd5456 合併邏輯，將相同品項的判斷寫在一起 jiajun.chou 2020-08-13 22:07:41 +0800
b713be03e6 移除多餘的區塊 for Sulfura 判斷 jiajun.chou 2020-08-13 22:00:27 +0800
5db134a70f 拆除多餘的 if else for sellin < 0 jiajun.chou 2020-08-13 21:55:35 +0800
ef7eb587ec Replace for array to foreach jiajun.chou 2020-08-13 21:40:59 +0800
e00567ab6a [Duplicated Code] extract to function jiajun.chou 2020-08-13 21:35:44 +0800
e49d0f62b4 將相同條件的判斷獨立出來 jiajun.chou 2020-08-13 21:31:35 +0800
9f2e89713f [Duplicated Code] extract to function jiajun.chou 2020-08-13 21:28:45 +0800
c4f6bc4d2a Inverse if statement jiajun.chou 2020-08-13 21:26:05 +0800
b74a4608d4 Add test case jiajun.chou 2020-08-13 21:24:35 +0800
4b94f81e2e Format Google Coding style jiajun.chou 2020-08-13 21:23:28 +0800
98ff07fb44 把每個item的運算都抽成function liaolizhen 2020-08-13 17:50:04 +0800
31f7d222ea 調整item.sellIn順序且將<0的判斷塞入 item.name的判斷式中 liaolizhen 2020-08-13 17:43:51 +0800
4cfe62665d extract increaseQuality & decreaseQuality function liaolizhen 2020-08-13 17:24:42 +0800
e224e973d6 將 Backstage passes 抽出 & Sulfuras 抽出判斷 liaolizhen 2020-08-13 17:03:50 +0800
bfcbd1c96f 把for loop改成foreach且把計算邏輯移到fuction方便閱讀 liaolizhen 2020-08-13 16:20:08 +0800
2f629ecc0e inverse if statement liaolizhen 2020-08-13 15:21:52 +0800
5564010b7b 加入test case & 修正 liaolizhen 2020-08-13 15:17:34 +0800
6631f5de37 Pass initial test for GildedRoseTest.cs Samuel Tran 2020-08-05 00:57:02 -0500
896ffacd33 Minor Update Samuel Tran 2020-08-05 00:43:52 -0500
39c2518254 Remove VS Files Samuel Tran 2020-08-04 20:17:25 -0500
6b7a1cd4ed Update Samuel Tran 2020-08-04 20:14:27 -0500
4ca30eb7b2 Unkwon Check piperfe 2020-07-29 18:22:47 -0400
82a70cf8e1 Unkwon Check piperfe 2020-07-29 18:22:07 -0400
3aa58d892d included test covering 100% iliana 2020-07-29 17:36:06 -0400
28443f97b2

Merge pull request #167 from mergermarket/ts-texttest Emily Bache 2020-07-27 10:32:26 +0200
ef5d1ffb9f

Merge pull request #166 from Pen-y-Fan/php72 Emily Bache 2020-07-27 10:29:35 +0200
ce38179dbd

Merge pull request #165 from rrokkam/rust-update Emily Bache 2020-07-27 10:26:09 +0200
185fa40b80

Merge pull request #164 from emilybache/dependabot/npm_and_yarn/js-jest/lodash-4.17.19 Emily Bache 2020-07-27 10:24:38 +0200
64d521d9a3 Create texttest settings for TypeScript version osh 2020-07-24 21:45:33 +0100
b4a02d3f5e Updated PHP version for PHP7.2+ Removed PHP5 (no longer supported) Renamed PHP7 to PHP - consistent with other kata Added the same helpers as other PHP Kata Updated the code to PHP7.2+ standard Didn't change GildedRose updateQuality method Updated GildedRoseTest (still failing) Added ApprovalTest (passing) - same text file as texttests / ThirtyDays / stdout.gr (only renamed). Pen-y-Fan 2020-07-23 22:49:59 +0100
ed7a787e4f Updated PHP version for PHP7.2+ Removed PHP5 (no longer supported) Renamed PHP7 to PHP - consistent with other kata Added the same helpers as other PHP Kata Updated the code to PHP7.2+ standard Didn't change GildedRose updateQuality method Updated GildedRoseTest (still failing) Added ApprovalTest (passing) - same text file as texttests / ThirtyDays / stdout.gr (only renamed). Pen-y-Fan 2020-07-23 22:47:36 +0100
4f7397935f Rename all tests name following the format when .... then should .... d0r019w 2020-07-20 18:50:28 -0400
a1e14123b8 Add test when when item is Backstage and sellIn is less than 6 and quality is less than 48 then should increase in 3 quality and decrease sellIn in 1 d0r019w 2020-07-20 18:34:25 -0400
fb09349e7d Merge branch 'master' of https://github.com/piperfe/GildedRose-Refactoring-Kata piperfe 2020-07-20 17:51:46 -0400
21e1be55e4 Init test cases in GildedRose market piperfe 2020-07-20 17:48:58 -0400
45e53e823b Bump to 2018 edition rrokkam 2020-07-19 13:41:08 -0700
d897d295b7 Update Cargo.toml; bump version number rrokkam 2020-07-19 13:33:33 -0700
2ebbc987fb Make Item::new take Into<String> as a name rrokkam 2020-07-19 13:18:50 -0700
c88bdfd53e Implement Display for Item rrokkam 2020-07-19 13:00:57 -0700
f21ed2ae13 Make main.rs clippy-clean rrokkam 2020-07-19 12:53:02 -0700
b9372efe6f Use 2018-edition field init shorthand rrokkam 2020-07-19 12:45:26 -0700
972e00541a Move gildedrose/mod.rs -> gildedrose.rs rrokkam 2020-07-19 12:39:57 -0700
87f3e536a4 Risky: Move tests into mod.rs rrokkam 2020-07-19 12:38:24 -0700
2a53bf5db5 Delete imports that are already in the prelude rrokkam 2020-07-19 12:35:37 -0700
a699803ce7 cargo fmt rrokkam 2020-07-19 12:33:57 -0700
c5543783cb

Bump lodash from 4.17.15 to 4.17.19 in /js-jest dependabot[bot] 2020-07-18 13:03:07 +0000
bccccf5861 chore: Refactor Golang code Irvi Firqotul Aini 2020-07-17 10:08:23 +0700
aa20f223ed removed unused languages I24004 2020-07-16 16:16:20 +0200
7ce46a24a7 Initial refactors/tests Jason Rall 2020-07-02 08:28:58 -0600
5e9ed0aa84 refactor: add specialized classes for handling each case Ben Leers 2020-06-29 11:05:49 +0200
1e257bc659 add tests for conjured items Ben Leers 2020-06-29 09:50:33 +0200
3a0735e237 Add Tests for current code base add GRItem add validation for initial quality values + tests Ben Leers 2020-06-29 09:42:08 +0200
07a39f281e

Create Kumari_Aastha_pyspark aasthakittu 2020-06-28 21:25:31 +0200
fbe24e35b5 starting test should fail at the start emily 2020-06-08 13:58:55 +0200
e1fdd00962 starting position should include item printer emily 2020-06-05 15:36:03 +0200
3ee479a731 new cpp version with just catch2 and approvals. Builds faster than the version in the cpp folder emily 2020-06-05 15:24:00 +0200
59fa896633

Merge pull request #157 from LarsEckart/master Emily Bache 2020-06-04 09:52:49 +0200
0f729f3192 update gradle wrapper & junit5 dependency Lars Eckart 2020-06-04 10:22:28 +0300
82a0083ead

Merge pull request #143 from fpellet/plpgsql_pgtap Emily Bache 2020-06-04 08:00:21 +0200
35d2cef888 use TEXTTEST_HOME instead of TEXTTEST_CHECKOUT since it is now set to current working directory in latest texttest version emily 2020-05-07 15:33:04 +0200
02d4c1db4a make texttest easier to use emily 2020-05-07 15:29:55 +0200
5d4b4ab839 improve docs for texttest emily 2020-05-07 15:17:55 +0200
3c3d60414f added ruby gitignore emily 2020-05-07 08:44:33 +0200
d0c9d06c1c added cpp version to texttest config Emily Bache 2020-05-06 09:22:16 +0000
7598ff7848 added texttests fixture to cpp version Emily Bache 2020-05-06 09:21:24 +0000
950b70eb2d configure for ec2 instance EC2 Default User 2020-05-06 07:41:49 +0000
deb9a3a5c9 - Group actual system information in README.md; - Create tests based on TexttestFixture class; Luciano Minuzzi 2020-05-02 22:49:00 +0200
b12a345e6c - Increase project information in README.md; - Refactor the foo test into "+5 Dexterity Vest" item test; Luciano Minuzzi 2020-05-02 19:33:32 +0200
58cf291e65 Revert "- Increase project information in README.md" Luciano Minuzzi 2020-05-02 19:30:43 +0200