diff --git a/.claude/commands/review.md b/.claude/commands/review.md index c1d750c8..20e9d859 100644 --- a/.claude/commands/review.md +++ b/.claude/commands/review.md @@ -12,5 +12,5 @@ Review the current changes (staged or recent commits) across all five axes: 4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill) 5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill) -Categorize findings as Critical, Important, or Suggestion. +Categorize findings as Critical, Required, Optional, or Nit. Output a structured review with specific file:line references and fix recommendations. diff --git a/.claude/commands/ship.md b/.claude/commands/ship.md index 1dfaf016..fa7b7efe 100644 --- a/.claude/commands/ship.md +++ b/.claude/commands/ship.md @@ -29,7 +29,7 @@ Constraints (from Claude Code's subagent model): Once all three reports are back, the main agent (not a sub-persona) synthesizes them: -1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. +1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. 2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis. 3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable. 4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist). diff --git a/.gemini/commands/review.toml b/.gemini/commands/review.toml index 23f5b78c..1810870a 100644 --- a/.gemini/commands/review.toml +++ b/.gemini/commands/review.toml @@ -11,6 +11,6 @@ Review the current changes (staged or recent commits) across all five axes: 4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill) 5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill) -Categorize findings as Critical, Important, or Suggestion. +Categorize findings as Critical, Required, Optional, or Nit. Output a structured review with specific file:line references and fix recommendations. """ \ No newline at end of file diff --git a/.gemini/commands/ship.toml b/.gemini/commands/ship.toml index af4a2a9b..98542092 100644 --- a/.gemini/commands/ship.toml +++ b/.gemini/commands/ship.toml @@ -28,7 +28,7 @@ Constraints (from Gemini CLI's subagent model): Once all three reports are back, the main agent (not a sub-persona) synthesizes them: -1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. +1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. 2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis. 3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable. 4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist). diff --git a/README.md b/README.md index fd5d76fd..7f610b8c 100644 --- a/README.md +++ b/README.md @@ -35,6 +35,8 @@ Skills encode the workflows, quality gates, and best practices that senior engin | Simplify the code | `/code-simplify` | Clarity over cleverness | | Ship to production | `/ship` | Faster is safer | +In Claude Code these install as plugin commands. Where a built-in command has the same name, as `/review` does, use the namespaced form: `/agent-skills:review`. + Want fewer manual steps once the spec exists? **`/build auto`** generates the plan and implements every task in a single approved pass — you approve the plan once, then it runs autonomously. It removes the human stepping *between* tasks, not the verification: every task is still test-driven and committed individually, and it pauses on failures or risky steps. Skills also activate automatically based on what you're doing — designing an API triggers `api-and-interface-design`, building UI triggers `frontend-ui-engineering`, and so on. diff --git a/agents/code-reviewer.md b/agents/code-reviewer.md index 156c0908..ea267be0 100644 --- a/agents/code-reviewer.md +++ b/agents/code-reviewer.md @@ -98,5 +98,5 @@ Categorize every finding, using the same severity labels as the `code-review-and ## Composition - **Invoke directly when:** the user asks for a review of a specific change, file, or PR. -- **Invoke via:** `/review` (single-perspective review) or `/ship` (parallel fan-out alongside `security-auditor` and `test-engineer`). +- **Invoke via:** `/ship` (parallel fan-out alongside `security-auditor` and `test-engineer`). `/review` runs the `code-review-and-quality` skill in the main session and does not spawn this persona. - **Do not invoke from another persona.** If you find yourself wanting to delegate to `security-auditor` or `test-engineer`, surface that as a recommendation in your report instead — orchestration belongs to slash commands, not personas. See [docs/agents.md](../docs/agents.md). diff --git a/agents/test-engineer.md b/agents/test-engineer.md index 19a41bad..d207e2f5 100644 --- a/agents/test-engineer.md +++ b/agents/test-engineer.md @@ -91,5 +91,5 @@ When analyzing test coverage: ## Composition - **Invoke directly when:** the user asks for test design, coverage analysis, or a Prove-It test for a specific bug. -- **Invoke via:** `/test` (TDD workflow) or `/ship` (parallel fan-out for coverage gap analysis alongside `code-reviewer` and `security-auditor`). +- **Invoke via:** `/ship` (parallel fan-out for coverage gap analysis alongside `code-reviewer` and `security-auditor`). `/test` runs the `test-driven-development` skill in the main session and does not spawn this persona. - **Do not invoke from another persona.** Recommendations to add tests belong in your report; the user or a slash command decides when to act on them. See [docs/agents.md](../docs/agents.md). diff --git a/commands/review.toml b/commands/review.toml index 23f5b78c..1810870a 100644 --- a/commands/review.toml +++ b/commands/review.toml @@ -11,6 +11,6 @@ Review the current changes (staged or recent commits) across all five axes: 4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill) 5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill) -Categorize findings as Critical, Important, or Suggestion. +Categorize findings as Critical, Required, Optional, or Nit. Output a structured review with specific file:line references and fix recommendations. """ \ No newline at end of file diff --git a/commands/ship.toml b/commands/ship.toml index bf0a7764..de2f9956 100644 --- a/commands/ship.toml +++ b/commands/ship.toml @@ -28,7 +28,7 @@ Constraints (from CLI's subagent model): Once all three reports are back, the main agent (not a sub-persona) synthesizes them: -1. **Code Quality** — Aggregate Critical/Important findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. +1. **Code Quality** — Aggregate Critical/Required findings from `code-reviewer` and any failing tests, lint, or build output. Resolve duplicates between reviewers. 2. **Security** — Promote any Critical/High `security-auditor` findings to launch blockers. Cross-reference with `code-reviewer`'s security axis. 3. **Performance** — Pull from `code-reviewer`'s performance axis; cross-check Core Web Vitals if applicable. 4. **Accessibility** — Verify keyboard nav, screen reader support, contrast (not covered by the three personas — handle directly here, or invoke the accessibility checklist). diff --git a/docs/agents.md b/docs/agents.md index 414177ba..e4ccea98 100644 --- a/docs/agents.md +++ b/docs/agents.md @@ -34,10 +34,10 @@ Pick this when you want one perspective on the current change and the user is in ### Slash command (single persona behind it) Pick this when there's a repeatable workflow you'd otherwise re-explain every time. -- `/review` → wraps `code-reviewer` with the project's review skill -- `/test` → wraps `test-engineer` with TDD skill - `/webperf` → wraps `web-performance-auditor` for performance-focused audits on web apps +`/review` and `/test` are not persona wrappers. They run the `code-review-and-quality` and `test-driven-development` skills in the main session, where the conversation's context is. To get `code-reviewer` or `test-engineer` in a fresh context, invoke the persona directly or run `/ship`. + ### Slash command (orchestrator — fan-out) Pick this only when **independent** investigations can run in parallel and produce reports that a single agent then merges.