mirror of
https://github.com/addyosmani/agent-skills.git
synced 2026-11-05 20:25:55 +00:00
Review on #600 (@abhisheksharma2411) found three cases in the threshold comparison: - Deleting one threshold from a rule that keeps others was silent: pairing was by position, and a threshold with no counterpart after the edit was skipped. It is now reported as threshold-removed. - A number inserted earlier in a rule shifted the pairing, so "per ADR 7, >= 80%" compared 80 against 7 and reported a loosened minimum. Numbers are now paired within their direction (minimum with minimum, maximum with maximum, undirected with undirected); an added number tightens and stays silent. - A renamed rule is still reported as rule-removed, since the key is the label and blocking is the safe default, and the output now says the label may have changed. The review's cases are in the test, plus a control that adding a threshold is silent: 21 pass, and the three review cases fail on the previous commit.