mirror of
https://github.com/addyosmani/agent-skills.git
synced 2026-10-26 15:05:04 +00:00
Addy Osmani
2bdbe1f5a6
docs/agents.md and two persona files said /review and /test wrap the code-reviewer and test-engineer personas. They invoke a skill in the main session and spawn nothing (#681). The review commands also still asked for Critical/Important/Suggestion while the skill and persona use Critical/Required/Optional/Nit, and /ship named the old labels.
16 lines
846 B
TOML
16 lines
846 B
TOML
description = "Conduct a five-axis code review — correctness, readability, architecture, security, performance"
|
|
|
|
prompt = """
|
|
Invoke the code-review-and-quality skill.
|
|
|
|
Review the current changes (staged or recent commits) across all five axes:
|
|
|
|
1. **Correctness** — Does it match the spec? Edge cases handled? Tests adequate?
|
|
2. **Readability** — Clear names? Straightforward logic? Well-organized?
|
|
3. **Architecture** — Follows existing patterns? Clean boundaries? Right abstraction level?
|
|
4. **Security** — Input validated? Secrets safe? Auth checked? (Use security-and-hardening skill)
|
|
5. **Performance** — No N+1 queries? No unbounded ops? (Use performance-optimization skill)
|
|
|
|
Categorize findings as Critical, Required, Optional, or Nit.
|
|
Output a structured review with specific file:line references and fix recommendations.
|
|
""" |