From ac03795fe6adb14f84c5634aa4a93a49543557e1 Mon Sep 17 00:00:00 2001
From: Michael Shamoon <4887959+shamoon@users.noreply.github.com>
Date: Fri, 14 Oct 2022 14:14:38 -0700
Subject: [PATCH] redesign ping & docker status

---
 public/locales/en/common.json      |  8 ++++++-
 src/components/services/item.jsx   | 38 ++++++++++++++++--------------
 src/components/services/ping.jsx   | 23 ++++++++++++------
 src/components/services/status.jsx | 27 +++++++++++++++++----
 src/pages/api/ping.js              |  3 +--
 5 files changed, 66 insertions(+), 33 deletions(-)

diff --git a/public/locales/en/common.json b/public/locales/en/common.json
index d53d480c..c1b35aa7 100644
--- a/public/locales/en/common.json
+++ b/public/locales/en/common.json
@@ -47,7 +47,13 @@
         "tx": "TX",
         "mem": "MEM",
         "cpu": "CPU",
-        "offline": "Offline"
+        "offline": "Offline",
+        "error": "Error",
+        "unknown": "Unknown"
+    },
+    "ping": {
+        "error": "Error",
+        "ping": "Ping"
     },
     "emby": {
         "playing": "Playing",
diff --git a/src/components/services/item.jsx b/src/components/services/item.jsx
index 25e94266..a4b54ad3 100644
--- a/src/components/services/item.jsx
+++ b/src/components/services/item.jsx
@@ -65,7 +65,7 @@ export default function Item({ service }) {
       <div
         className={`${
           hasLink ? "cursor-pointer " : " "
-        }transition-all h-15 mb-3 p-1 rounded-md font-medium text-theme-700 dark:text-theme-200 dark:hover:text-theme-300 shadow-md shadow-theme-900/10 dark:shadow-theme-900/20 bg-theme-100/20 hover:bg-theme-300/20 dark:bg-white/5 dark:hover:bg-white/10`}
+        }transition-all h-15 mb-3 p-1 rounded-md font-medium text-theme-700 dark:text-theme-200 dark:hover:text-theme-300 shadow-md shadow-theme-900/10 dark:shadow-theme-900/20 bg-theme-100/20 hover:bg-theme-300/20 dark:bg-white/5 dark:hover:bg-white/10 relative`}
       >
         <div className="flex select-none">
           {service.icon &&
@@ -103,23 +103,25 @@ export default function Item({ service }) {
             </div>
           )}
 
-          {service.ping && (
-            <div className="flex-shrink-0 flex items-center justify-center w-5 mr-4 cursor-pointer">
-              <Ping service={service} />
-              <span className="sr-only">Ping status</span>
-            </div>
-          )}
-
-          {service.container && (
-            <button
-              type="button"
-              onClick={() => (statsOpen ? closeStats() : setStatsOpen(true))}
-              className="flex-shrink-0 flex items-center justify-center w-5 mr-4 cursor-pointer"
-            >
-              <Status service={service} />
-              <span className="sr-only">View container stats</span>
-            </button>
-          )}
+          <div className="absolute top-0 right-0 w-1/2 flex flex-row justify-end gap-2 mr-2">
+              {service.container && (
+                <button
+                  type="button"
+                  onClick={() => (statsOpen ? closeStats() : setStatsOpen(true))}
+                  className="flex-shrink-0 flex items-center justify-center cursor-pointer"
+                >
+                  <Status service={service} />
+                  <span className="sr-only">View container stats</span>
+                </button>
+              )}
+              
+              {service.ping && (
+                <div className="flex-shrink-0 flex items-center justify-center cursor-pointer">
+                  <Ping service={service} />
+                  <span className="sr-only">Ping status</span>
+                </div>
+              )}
+          </div>
         </div>
 
         {service.container && service.server && (
diff --git a/src/components/services/ping.jsx b/src/components/services/ping.jsx
index 951a624d..18ad8696 100644
--- a/src/components/services/ping.jsx
+++ b/src/components/services/ping.jsx
@@ -1,33 +1,42 @@
-import { BsArrowDownCircle, BsArrowUpCircle } from "react-icons/bs";
+import { useTranslation } from "react-i18next";
 import useSWR from "swr";
 
 export default function Ping({ service }) {
+  const { t } = useTranslation();
   const { data, error } = useSWR(`/api/ping?${new URLSearchParams({ping: service.ping}).toString()}`, {
     refreshInterval: 5000
   });
 
   if (error) {
-    return <div className="w-3 h-3 text-xs text-rose-300 dark:text-rose-500" title={data.status}>&darr;</div>;
+    return (
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden">
+        <div className="text-[8px] font-bold text-rose-500 uppercase">{t("ping.error")}</div>
+      </div>
+    );
   }
   
   if (!data) {
-    return <div className="w-3 h-3 text-[10px] text-black/20 dark:text-white/40">PING</div>;
+    return (
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden">
+        <div className="text-[8px] font-bold text-black/20 dark:text-white/40 uppercase">{t("ping.ping")}</div>
+      </div>
+    );
   }
 
   const statusText = `${service.ping}: HTTP status ${data.status}`;
   
   if (data && data.status !== 200) {
     return (
-      <div className="w-3 h-3 text-xs text-rose-300 dark:text-rose-500" title={statusText}>
-        <BsArrowDownCircle />
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden" title={statusText}>
+        <div className="text-[8px] font-bold text-rose-500/80">{data.status}</div>
       </div>
     );
   }
   
   if (data && data.status === 200) {
     return (
-      <div className="w-3 h-3 text-xs text-emerald-300 dark:text-emerald-500" title={statusText}>
-        <BsArrowUpCircle />
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden" title={statusText}>
+        <div className="text-[8px] font-bold text-emerald-500/80">{data.status}</div>
       </div>
     );
   }
diff --git a/src/components/services/status.jsx b/src/components/services/status.jsx
index dc903408..2d07e49e 100644
--- a/src/components/services/status.jsx
+++ b/src/components/services/status.jsx
@@ -1,19 +1,36 @@
+import { useTranslation } from "react-i18next";
 import useSWR from "swr";
 
 export default function Status({ service }) {
+  const { t } = useTranslation();
+
   const { data, error } = useSWR(`/api/docker/status/${service.container}/${service.server || ""}`);
 
   if (error) {
-    return <div className="w-3 h-3 bg-rose-300 dark:bg-rose-500 rounded-full" />;
+    <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden" title={data.status}>
+      <div className="text-[8px] font-bold text-rose-500/80 uppercase">{t("docker.error")}</div>
+    </div>
   }
 
   if (data && data.status === "running") {
-    return <div className="w-3 h-3 bg-emerald-300 dark:bg-emerald-500 rounded-full" />;
+    return (
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden" title={data.status}>
+        <div className="text-[8px] font-bold text-emerald-500/80 uppercase">{data.status}</div>
+      </div>
+    );
   }
 
-  if (data && data.status === "not found") {
-    return <div className="h-2.5 w-2.5 bg-orange-400/50 dark:bg-yellow-200/40 -rotate-45" />;
+  if (data && (data.status === "not found" || data.status === "exited")) {
+    return (
+      <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden" title={data.status}>
+        <div className="text-[8px] font-bold text-orange-400/50 dark:text-orange-400/80 uppercase">{data.status}</div>
+      </div>
+    );
   }
 
-  return <div className="w-3 h-3 bg-black/20 dark:bg-white/40 rounded-full" />;
+  return (
+    <div className="w-auto px-1.5 py-0.5 text-center bg-theme-500/10 dark:bg-theme-900/50 rounded-b-[3px] overflow-hidden">
+      <div className="text-[8px] font-bold text-black/20 dark:text-white/40 uppercase">{t("docker.unknown")}</div>
+    </div>
+  );
 }
diff --git a/src/pages/api/ping.js b/src/pages/api/ping.js
index 548f1d9b..46ffda65 100644
--- a/src/pages/api/ping.js
+++ b/src/pages/api/ping.js
@@ -1,4 +1,3 @@
-import { servicesFromConfig } from "utils/config/service-helpers";
 import createLogger from "utils/logger";
 import { httpProxy } from "utils/proxy/http";
 
@@ -17,6 +16,6 @@ export default async function handler(req, res) {
     const [status] = await httpProxy(pingURL);
 
     return res.status(200).json({
-      status: status,
+      status,
     });
 }