From 0202466b710fdfda28dbadf9cfa6d18fb2ef4d19 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Thu, 8 Feb 2007 17:32:18 +0000 Subject: [PATCH] DefaultClassRealm in classworlds is child-first delegation, so when loading classes in a child container (which creates its own realm), MojoScanner interface ends up loaded locally. So really the only solution is to hide the maven-plugin-tools-api.jar from embedded Maven. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@2107 71c3de6d-444a-0410-be80-ed276b4c234a --- .../src/main/java/hudson/maven/MavenUtil.java | 39 ++++++++++++++++++- 1 file changed, 38 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/maven/MavenUtil.java b/core/src/main/java/hudson/maven/MavenUtil.java index dcb8b3a1a8..2e4cbb04aa 100644 --- a/core/src/main/java/hudson/maven/MavenUtil.java +++ b/core/src/main/java/hudson/maven/MavenUtil.java @@ -6,9 +6,12 @@ import org.apache.maven.project.MavenProject; import org.apache.maven.project.ProjectBuildingException; import java.io.File; +import java.io.IOException; import java.util.ArrayList; import java.util.List; import java.util.Map; +import java.util.Enumeration; +import java.net.URL; /** * @author Kohsuke Kawaguchi @@ -24,7 +27,7 @@ class MavenUtil { MavenEmbedder maven = new MavenEmbedder(); ClassLoader cl = MavenUtil.class.getClassLoader(); - maven.setClassLoader(cl); + maven.setClassLoader(new MaskingClassLoader(cl)); maven.setLogger( new EmbedderLoggerImpl(listener) ); // if we let Plexus find components, there's no guaranteed ordering, // so Plexus may well find the DefaultPluginManager from maven.jar instead of @@ -70,4 +73,38 @@ class MavenUtil { project.setCollectedProjects(modules); } + + private static final class MaskingClassLoader extends ClassLoader { + + public MaskingClassLoader(ClassLoader parent) { + super(parent); + } + + public Enumeration getResources(String name) throws IOException { + final Enumeration e = super.getResources(name); + return new Enumeration() { + URL next; + + public boolean hasMoreElements() { + fetch(); + return next!=null; + } + + public URL nextElement() { + fetch(); + URL r = next; + next = null; + return r; + } + + private void fetch() { + while(next==null && e.hasMoreElements()) { + next = e.nextElement(); + if(next.toExternalForm().contains("maven-plugin-tools-api")) + next = null; + } + } + }; + } + } }