From 081c0ce6f4dd71d700548bc7ec9891dfa365bad2 Mon Sep 17 00:00:00 2001 From: Basil Crow Date: Sat, 4 Dec 2021 18:27:20 -0800 Subject: [PATCH] Fix `JLM_JSR166_UTILCONCURRENT_MONITORENTER` SpotBugs violations --- core/src/main/java/hudson/PluginManager.java | 4 +--- src/spotbugs/spotbugs-excludes.xml | 4 ---- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index d067ed49fe..7dad538d6f 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -911,9 +911,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas plugins.add(p); if (p.isActive()) activePlugins.add(p); - synchronized (((UberClassLoader) uberClassLoader).loaded) { - ((UberClassLoader) uberClassLoader).loaded.clear(); - } + ((UberClassLoader) uberClassLoader).loaded.clear(); // TODO antimodular; perhaps should have a PluginListener to complement ExtensionListListener? CustomClassFilter.Contributed.load(); diff --git a/src/spotbugs/spotbugs-excludes.xml b/src/spotbugs/spotbugs-excludes.xml index ccd7c6f5c7..b825555ade 100644 --- a/src/spotbugs/spotbugs-excludes.xml +++ b/src/spotbugs/spotbugs-excludes.xml @@ -228,10 +228,6 @@ - - - -