From 11f301b5ee61ea1c6ae91dd2121da53b4493be34 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Thu, 21 Feb 2019 00:23:53 -0500 Subject: [PATCH] StringBuilder.append() supports slicing --- core/src/main/java/hudson/Util.java | 2 +- core/src/main/java/hudson/util/ArgumentListBuilder.java | 2 +- core/src/main/java/hudson/util/SecretRewriter.java | 2 +- core/src/main/java/jenkins/model/Jenkins.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/Util.java b/core/src/main/java/hudson/Util.java index dc3de475bf..5b07592761 100644 --- a/core/src/main/java/hudson/Util.java +++ b/core/src/main/java/hudson/Util.java @@ -870,7 +870,7 @@ public class Util { if (c > 122 || uriMap[c]) { if (!escaped) { out = new StringBuilder(i + (m - i) * 3); - out.append(s.substring(0, i)); + out.append(s, 0, i); enc = StandardCharsets.UTF_8.newEncoder(); buf = CharBuffer.allocate(1); escaped = true; diff --git a/core/src/main/java/hudson/util/ArgumentListBuilder.java b/core/src/main/java/hudson/util/ArgumentListBuilder.java index 4962892658..936a30a9c0 100644 --- a/core/src/main/java/hudson/util/ArgumentListBuilder.java +++ b/core/src/main/java/hudson/util/ArgumentListBuilder.java @@ -376,7 +376,7 @@ public class ArgumentListBuilder implements Serializable, Cloneable { } private static boolean startQuoting(StringBuilder buf, String arg, int atIndex) { - buf.append('"').append(arg.substring(0, atIndex)); + buf.append('"').append(arg, 0, atIndex); return true; } diff --git a/core/src/main/java/hudson/util/SecretRewriter.java b/core/src/main/java/hudson/util/SecretRewriter.java index ab4afceee1..5a11e41847 100644 --- a/core/src/main/java/hudson/util/SecretRewriter.java +++ b/core/src/main/java/hudson/util/SecretRewriter.java @@ -106,7 +106,7 @@ public class SecretRewriter { if (!replacement.equals(elementText)) modified = true; - buf.append(line.substring(copied, sidx + 1)); + buf.append(line, copied, sidx + 1); buf.append(replacement); copied = eidx; } diff --git a/core/src/main/java/jenkins/model/Jenkins.java b/core/src/main/java/jenkins/model/Jenkins.java index 20ed762465..db908fe819 100644 --- a/core/src/main/java/jenkins/model/Jenkins.java +++ b/core/src/main/java/jenkins/model/Jenkins.java @@ -2326,7 +2326,7 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve buf.append(host); } else { // Nginx uses the same spec as for the Host header, i.e. hostname:port - buf.append(host.substring(0, index)); + buf.append(host, 0, index); if (index + 1 < host.length()) { try { port = Integer.parseInt(host.substring(index + 1));