From 1259aa9cf42e0f210aaa3295d397b952de403cd6 Mon Sep 17 00:00:00 2001
From: Kohsuke Kawaguchi <kk@kohsuke.org>
Date: Fri, 14 Jan 2011 11:14:08 -0800
Subject: [PATCH] Improved the error diagnostics based on feedback.

See
http://groups.google.com/group/hudson-users/browse_frm/thread/4272c82edb5460b8
"Install-plugin CLI action doesn't work when an URL is specified as
SOURCE"
---
 .../java/hudson/cli/InstallPluginCommand.java | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/core/src/main/java/hudson/cli/InstallPluginCommand.java b/core/src/main/java/hudson/cli/InstallPluginCommand.java
index fac26b5406..4616e823a9 100644
--- a/core/src/main/java/hudson/cli/InstallPluginCommand.java
+++ b/core/src/main/java/hudson/cli/InstallPluginCommand.java
@@ -27,14 +27,18 @@ import hudson.Extension;
 import hudson.FilePath;
 import hudson.model.Hudson;
 import hudson.model.UpdateSite;
+import hudson.model.UpdateSite.Data;
+import hudson.util.EditDistance;
 import org.kohsuke.args4j.Argument;
 import org.kohsuke.args4j.Option;
 
 import java.io.File;
 import java.net.URL;
 import java.net.MalformedURLException;
+import java.util.HashSet;
 import java.util.List;
 import java.util.ArrayList;
+import java.util.Set;
 
 /**
  * Installs a plugin either from a file, an URL, or from update center.
@@ -101,6 +105,23 @@ public class InstallPluginCommand extends CLICommand {
             }
 
             stdout.println(source+" is neither a valid file, URL, nor a plugin artifact name in the update center");
+
+            if (!source.contains(".") && !source.contains(":") && !source.contains("/") && !source.contains("\\")) {
+                // looks like a short plugin name. Why did we fail to find it in the update center?
+                if (h.getUpdateCenter().getSites().isEmpty()) {
+                    stdout.println("Note that no update center is defined in this Hudson.");
+                } else {
+                    Set<String> candidates = new HashSet<String>();
+                    for (UpdateSite s : h.getUpdateCenter().getSites()) {
+                        Data dt = s.getData();
+                        if (dt==null)
+                            stdout.println("No update center data is retrieved yet from: "+s.getUrl());
+                        candidates.addAll(dt.plugins.keySet());
+                    }
+                    stdout.println(source+" looks like a short plugin name. Did you mean '"+ EditDistance.findNearest(source,candidates)+"'?");
+                }
+            }
+
             return 1;
         }