From 16ee6c7f3138541b1d4ffff1dd02ca12fc917b5f Mon Sep 17 00:00:00 2001 From: kohsuke Date: Sat, 19 May 2007 08:23:50 +0000 Subject: [PATCH] added defensive code to fix the NPE as reported below: I sporadically get a NPE when trying to send an email at the end of a build: Recording test results FATAL: null java.lang.NullPointerException at hudson.tasks.MailSender.createFailureMail(MailSender.java:157) at hudson.tasks.MailSender.getMail(MailSender.java:87) at hudson.tasks.MailSender.execute(MailSender.java:64) at hudson.tasks.Mailer.perform(Mailer.java:61) at hudson.model.Build$RunnerImpl.post(Build.java:137) at hudson.model.Run.run(Run.java:573) at hudson.model.Build.run(Build.java:101) at hudson.model.Executor.run(Executor.java:61) I haven't narrowed down if this happens only for failed builds or for any build. Once it happens the only way it goes away is if I clear the email option, save, and reset it. Any ideas what's going on? Rich ePlus Consulting -- View this message in context: http://www.nabble.com/NPE-trying-to-send-email-tf3772528.html#a10666153 Sent from the Hudson users mailing list archive at Nabble.com. --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@hudson.dev.java.net For additional commands, e-mail: users-help@hudson.dev.java.net git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3345 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/model/User.java | 3 +++ core/src/main/java/hudson/scm/CVSChangeLogSet.java | 2 ++ core/src/main/java/hudson/scm/SubversionChangeLogSet.java | 2 ++ 3 files changed, 7 insertions(+) diff --git a/core/src/main/java/hudson/model/User.java b/core/src/main/java/hudson/model/User.java index 55bcce97a9..a7b622ad4e 100644 --- a/core/src/main/java/hudson/model/User.java +++ b/core/src/main/java/hudson/model/User.java @@ -139,6 +139,9 @@ public class User extends AbstractModelObject { } + public static User getUnknown() { + return get("unknown"); + } public static User get(String name) { if(name==null) diff --git a/core/src/main/java/hudson/scm/CVSChangeLogSet.java b/core/src/main/java/hudson/scm/CVSChangeLogSet.java index 961291076b..12de6bd598 100644 --- a/core/src/main/java/hudson/scm/CVSChangeLogSet.java +++ b/core/src/main/java/hudson/scm/CVSChangeLogSet.java @@ -147,6 +147,8 @@ public final class CVSChangeLogSet extends ChangeLogSet { @Exported public User getAuthor() { + if(author==null) + return User.getUnknown(); return author; } diff --git a/core/src/main/java/hudson/scm/SubversionChangeLogSet.java b/core/src/main/java/hudson/scm/SubversionChangeLogSet.java index bd816467a9..45b0a9fc8d 100644 --- a/core/src/main/java/hudson/scm/SubversionChangeLogSet.java +++ b/core/src/main/java/hudson/scm/SubversionChangeLogSet.java @@ -92,6 +92,8 @@ public final class SubversionChangeLogSet extends ChangeLogSet { @Override public User getAuthor() { + if(author==null) + return User.getUnknown(); return author; }