From 1c698565fa3886f0c5fa6ea999af2802e8eee2ce Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 6 Aug 2008 17:04:15 +0000 Subject: [PATCH] fixed a stream leak git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11275 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/PluginWrapper.java | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/hudson/PluginWrapper.java b/core/src/main/java/hudson/PluginWrapper.java index ee027da13f..3cf835fe24 100644 --- a/core/src/main/java/hudson/PluginWrapper.java +++ b/core/src/main/java/hudson/PluginWrapper.java @@ -147,12 +147,17 @@ public final class PluginWrapper { if(isLinked) { // resolve the .hpl file to the location of the manifest file - String firstLine = new BufferedReader(new FileReader(archive)).readLine(); - if(firstLine.startsWith("Manifest-Version:")) { - // this is the manifest already - } else { - // indirection - archive = resolve(archive, firstLine); + BufferedReader archiveReader = new BufferedReader(new FileReader(archive)); + try { + String firstLine = archiveReader.readLine(); + if(firstLine.startsWith("Manifest-Version:")) { + // this is the manifest already + } else { + // indirection + archive = resolve(archive, firstLine); + } + } finally { + archiveReader.close(); } // then parse manifest FileInputStream in = new FileInputStream(archive);