From 1e9cc3b4e303a11fb14da6b640215b4e2bb53f74 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Tue, 30 Jun 2009 15:54:59 +0000 Subject: [PATCH] Fixed a possible "Cannot create a file when that file already exists" error in managed Windows slave launcher. report SmbFile.mkdirs() behave differently to File.mkdirs(), and it fails if the directory already exists. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19321 71c3de6d-444a-0410-be80-ed276b4c234a --- .../hudson/os/windows/ManagedWindowsServiceLauncher.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java b/core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java index cae43eb2f4..e14f5c7a8b 100644 --- a/core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java +++ b/core/src/main/java/hudson/os/windows/ManagedWindowsServiceLauncher.java @@ -117,8 +117,9 @@ public class ManagedWindowsServiceLauncher extends ComputerLauncher { logger.println(Messages.ManagedWindowsServiceLauncher_DotNetRequired()); return; } - - remoteRoot.mkdirs(); + + if(!remoteRoot.exists()) + remoteRoot.mkdirs(); // copy exe logger.println(Messages.ManagedWindowsServiceLauncher_CopyingSlaveExe());