From 1f7c75d7e553d77d643e488743601046c807f5cf Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 23 Sep 2011 23:17:26 -0700 Subject: [PATCH] Using String like enum isn't type safe. --- .../java/hudson/maven/MavenModuleSet.java | 18 ++++++++----- .../hudson/maven/MavenModuleSetBuild.java | 25 +------------------ 2 files changed, 13 insertions(+), 30 deletions(-) diff --git a/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java b/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java index 991004fdcb..459c48945e 100644 --- a/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java +++ b/maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java @@ -31,6 +31,7 @@ import hudson.EnvVars; import hudson.Extension; import hudson.ExtensionList; import hudson.FilePath; +import hudson.Functions; import hudson.Indenter; import hudson.Util; import hudson.maven.settings.GlobalMavenSettingsProvider; @@ -38,6 +39,7 @@ import hudson.maven.settings.MavenSettingsProvider; import hudson.model.AbstractProject; import hudson.model.Action; import hudson.model.BuildableItemWithBuildWrappers; +import hudson.model.Result; import hudson.tasks.Builder; import hudson.model.DependencyGraph; import hudson.model.Descriptor; @@ -265,7 +267,7 @@ public class MavenModuleSet extends AbstractMavenProject> postbuilders = new DescribableList>(this); - private String runPostStepsIfResult; + private Result runPostStepsIfResult; /** @@ -299,10 +301,14 @@ public class MavenModuleSet extends AbstractMavenProject