From 21a90bf60b229ae16ae3f48fb2d1bf4ed5c968fc Mon Sep 17 00:00:00 2001 From: kohsuke Date: Sun, 17 Jun 2007 22:17:58 +0000 Subject: [PATCH] added a debug probe for issue #591 "Unable to lock working copy" git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3470 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/scm/SubversionSCM.java | 6 ++++++ core/src/main/java/hudson/triggers/SCMTrigger.java | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/scm/SubversionSCM.java b/core/src/main/java/hudson/scm/SubversionSCM.java index 96d08baba8..8cf26fdc4a 100644 --- a/core/src/main/java/hudson/scm/SubversionSCM.java +++ b/core/src/main/java/hudson/scm/SubversionSCM.java @@ -4,11 +4,13 @@ import hudson.FilePath; import hudson.FilePath.FileCallable; import hudson.Launcher; import hudson.Util; +import hudson.triggers.SCMTrigger; import hudson.model.AbstractBuild; import hudson.model.AbstractProject; import hudson.model.BuildListener; import hudson.model.Hudson; import hudson.model.TaskListener; +import hudson.model.SCMedItem; import hudson.remoting.Callable; import hudson.remoting.Channel; import hudson.remoting.VirtualChannel; @@ -306,6 +308,10 @@ public class SubversionSCM extends SCM implements Serializable { } catch (SVNException e) { e.printStackTrace(listener.error("Failed to update "+l.remote)); + // trouble-shooting probe for #591 + if(e.getErrorMessage().getErrorCode()==SVNErrorCode.WC_NOT_LOCKED) { + listener.getLogger().println("Polled jobs are "+SCMTrigger.DESCRIPTOR.getItemsBeingPolled()); + } return null; } } diff --git a/core/src/main/java/hudson/triggers/SCMTrigger.java b/core/src/main/java/hudson/triggers/SCMTrigger.java index f7a6dbe2b8..11ab82ed80 100644 --- a/core/src/main/java/hudson/triggers/SCMTrigger.java +++ b/core/src/main/java/hudson/triggers/SCMTrigger.java @@ -21,6 +21,8 @@ import java.util.Date; import java.util.Set; import java.util.Collections; import java.util.HashSet; +import java.util.List; +import java.util.Arrays; import java.util.concurrent.CancellationException; import java.util.concurrent.ExecutionException; import java.util.concurrent.ExecutorService; @@ -164,8 +166,8 @@ public class SCMTrigger extends Trigger { * Gets the snapshot of {@link SCMedItem}s that are being polled at this very moment. * Designed for trouble-shooting probe. */ - public SCMedItem[] getItemsBeingPolled() { - return items.toArray(new SCMedItem[0]); + public List getItemsBeingPolled() { + return Arrays.asList(items.toArray(new SCMedItem[0])); } public String getDisplayName() {