diff --git a/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java b/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java index 3db25892ab..5e59ab1d6e 100644 --- a/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java +++ b/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java @@ -95,6 +95,7 @@ public class DefaultCrumbIssuer extends CrumbIssuer { if (request instanceof HttpServletRequest) { String newCrumb = issueCrumb(request, salt); if ((newCrumb != null) && (crumb != null)) { + // String.equals() is not constant-time, but this is return MessageDigest.isEqual(newCrumb.getBytes(), crumb.getBytes()); } }