From 281cd6c69a8af6a8b898b8011fb5bda6d3fcbbfb Mon Sep 17 00:00:00 2001 From: Daniel Beck Date: Wed, 27 Jan 2016 13:39:27 +0100 Subject: [PATCH] [SECURITY-245] Add explanation comment --- core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java b/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java index 3db25892ab..5e59ab1d6e 100644 --- a/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java +++ b/core/src/main/java/hudson/security/csrf/DefaultCrumbIssuer.java @@ -95,6 +95,7 @@ public class DefaultCrumbIssuer extends CrumbIssuer { if (request instanceof HttpServletRequest) { String newCrumb = issueCrumb(request, salt); if ((newCrumb != null) && (crumb != null)) { + // String.equals() is not constant-time, but this is return MessageDigest.isEqual(newCrumb.getBytes(), crumb.getBytes()); } }