From 2e3febe52159afcab7f45dfaee016a1aa265d90c Mon Sep 17 00:00:00 2001 From: kohsuke Date: Thu, 28 Jun 2007 01:51:26 +0000 Subject: [PATCH] if no entry is created, we end up trying to write over while we still have one more file handle open. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3584 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/scm/SubversionSCM.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/scm/SubversionSCM.java b/core/src/main/java/hudson/scm/SubversionSCM.java index 73454ce276..c26b704e45 100644 --- a/core/src/main/java/hudson/scm/SubversionSCM.java +++ b/core/src/main/java/hudson/scm/SubversionSCM.java @@ -179,12 +179,14 @@ public class SubversionSCM extends SCM implements Serializable { // maybe some XSLT engine doesn't close the stream properly. // so let's do it by ourselves to be really sure that the stream gets closed. OutputStream os = new BufferedOutputStream(new FileOutputStream(changelogFile)); + boolean created; try { - if(!new SubversionChangeLogBuilder(build,listener,this).run(externals,new StreamResult(os))) - createEmptyChangeLog(changelogFile, listener, "log"); + created = new SubversionChangeLogBuilder(build, listener, this).run(externals, new StreamResult(os)); } finally { os.close(); } + if(!created) + createEmptyChangeLog(changelogFile, listener, "log"); return true; }