mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-13 20:12:14 +00:00
Ensure that the Readers are closed properly
This commit is contained in:
1 parent
b58044ada6
commit
386ec0d15e
7 files changed
+72
-41
No files matched your search
@@ -32,6 +32,7 @@ import java.io.File;
|
||||
import java.io.FileInputStream;
|
||||
import java.io.FileOutputStream;
|
||||
import java.io.IOException;
|
||||
import java.io.InputStream;
|
||||
import java.io.InputStreamReader;
|
||||
import java.io.OutputStreamWriter;
|
||||
import java.io.Writer;
|
||||
@@ -123,9 +124,7 @@ public class Main {
|
||||
HttpURLConnection con = open(new URL(home +
|
||||
"crumbIssuer/api/xml?xpath=concat(//crumbRequestField,\":\",//crumb)'"));
|
||||
if (auth != null) con.setRequestProperty("Authorization", auth);
|
||||
BufferedReader in = new BufferedReader(new InputStreamReader(con.getInputStream()));
|
||||
String line = in.readLine();
|
||||
in.close();
|
||||
String line = readFirstLine(con.getInputStream());
|
||||
String[] components = line.split(":");
|
||||
if (components.length == 2) {
|
||||
crumbField = components[0];
|
||||
@@ -197,6 +196,15 @@ public class Main {
|
||||
}
|
||||
}
|
||||
|
||||
private static String readFirstLine(InputStream is) throws IOException {
|
||||
BufferedReader reader = new BufferedReader(new InputStreamReader(is));
|
||||
try {
|
||||
return reader.readLine();
|
||||
} finally {
|
||||
reader.close();
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Connects to the given HTTP URL and configure time out, to avoid infinite hang.
|
||||
*/
|
||||
|
||||
Reference in new issue
Block a user