Do not skip tests silently

This commit is contained in:
Oliver Gondža committed 2015-10-01 08:58:31 +02:00
1 parent 699d2b22ad
commit 3990384257
11 files changed
+35 -40

No files matched your search

+2 -1
View File
@@ -58,6 +58,7 @@ import org.apache.tools.ant.Project;
import org.apache.tools.ant.taskdefs.Chmod;
import static org.junit.Assert.*;
import static org.junit.Assume.assumeTrue;
import static org.junit.Assume.assumeFalse;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
@@ -464,7 +465,7 @@ public class FilePathTest {
}
@Test public void symlinkInTar() throws Exception {
if (Functions.isWindows()) return; // can't test on Windows
assumeFalse("can't test on Windows", Functions.isWindows());
FilePath tmp = new FilePath(temp.getRoot());
FilePath in = tmp.child("in");
+3 -4
View File
@@ -34,6 +34,8 @@ import java.io.File;
import jenkins.security.MasterToSlaveCallable;
import org.apache.commons.io.FileUtils;
import static org.junit.Assert.*;
import org.junit.Assume;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
@@ -46,10 +48,7 @@ public class LauncherTest {
@Issue("JENKINS-4611")
@Test public void remoteKill() throws Exception {
if (File.pathSeparatorChar != ':') {
System.err.println("Skipping, currently Unix-specific test");
return;
}
Assume.assumeFalse("Skipping, currently Unix-specific test", Functions.isWindows());
File tmp = temp.newFile();
@@ -8,6 +8,8 @@ import java.io.IOException;
import java.io.Serializable;
import jenkins.security.MasterToSlaveCallable;
import static org.junit.Assert.*;
import org.junit.Assume;
import org.junit.Rule;
import org.junit.Test;
@@ -26,9 +28,7 @@ public class ProcessTreeTest {
}
@Test public void remoting() throws Exception {
// on some platforms where we fail to list any processes, this test will just not work
if (ProcessTree.get()==ProcessTree.DEFAULT)
return;
Assume.assumeFalse("on some platforms where we fail to list any processes", ProcessTree.get()==ProcessTree.DEFAULT);
Tag t = channels.french.call(new MyCallable());