From 3b1d02facab603a02dd036bbb53fe14616d58bd3 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Tue, 25 Dec 2007 02:40:03 +0000 Subject: [PATCH] permissions granted to anonymous users are granted to everyone git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6418 71c3de6d-444a-0410-be80-ed276b4c234a --- .../security/GlobalMatrixAuthorizationStrategy.java | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java b/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java index 084a82903b..49319b8ca1 100644 --- a/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java +++ b/core/src/main/java/hudson/security/GlobalMatrixAuthorizationStrategy.java @@ -11,6 +11,7 @@ import net.sf.json.JSONObject; import org.acegisecurity.acls.sid.GrantedAuthoritySid; import org.acegisecurity.acls.sid.PrincipalSid; import org.acegisecurity.acls.sid.Sid; +import org.acegisecurity.Authentication; import org.kohsuke.stapler.StaplerRequest; import java.util.ArrayList; @@ -100,7 +101,13 @@ public class GlobalMatrixAuthorizationStrategy extends AuthorizationStrategy { if(GlobalMatrixAuthorizationStrategy.this.hasPermission(toString(p),permission)) return true; return null; + } + protected Boolean _hasPermission(Authentication a, Permission permission) { + Boolean b = super._hasPermission(a,permission); + // permissions granted to anonymous users are granted to everyone + if(b==null) b=hasPermission(ANONYMOUS,permission); + return b; } private String toString(Sid p) { @@ -184,7 +191,7 @@ public class GlobalMatrixAuthorizationStrategy extends AuthorizationStrategy { } public String getHelpFile() { - return "/help/security/full-control-once-logged-in.html"; + return "/help/security/global-matrix.html"; } public List getAllGroups() {