From 3bb6f4efcbb7a97cc86e2dc2550005fe732ebdc8 Mon Sep 17 00:00:00 2001 From: Christoph Kutzinski Date: Sun, 4 Dec 2011 12:35:11 +0100 Subject: [PATCH] - removed unused method - doc update --- core/src/main/java/hudson/model/AbstractProject.java | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java index 075fc3d48e..2de8160708 100644 --- a/core/src/main/java/hudson/model/AbstractProject.java +++ b/core/src/main/java/hudson/model/AbstractProject.java @@ -1193,7 +1193,9 @@ public abstract class AbstractProject

,R extends A workspace.mkdirs(); boolean r = scm.checkout(build, launcher, workspace, listener, changelogFile); - if (r) { // Only calcRevisionsFromBuild is checkout was successful + if (r) { + // Only calcRevisionsFromBuild if checkout was successful. Note that modern SCM implementations + // won't reach this line anyway, as they throw AbortExceptions on checkout failure. calcPollingBaseline(build, launcher, listener); } return r; @@ -1216,13 +1218,6 @@ public abstract class AbstractProject

,R extends A pollingBaseline = baseline; } - /** - * For reasons I don't understand, if I inline this method, AbstractMethodError escapes try/catch block. - */ - private SCMRevisionState safeCalcRevisionsFromBuild(AbstractBuild build, Launcher launcher, TaskListener listener) throws IOException, InterruptedException { - return getScm()._calcRevisionsFromBuild(build, launcher, listener); - } - /** * Checks if there's any update in SCM, and returns true if any is found. *