From 3dcabc4b026750906a1d16a54b4296fe50ceb402 Mon Sep 17 00:00:00 2001 From: Jan Faracik <43062514+janfaracik@users.noreply.github.com> Date: Tue, 14 Dec 2021 08:27:21 +0000 Subject: [PATCH] Modernise the appearance of the plugin manager (#5916) Co-authored-by: Joseph Petersen Co-authored-by: Tim Jacomb Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> --- .editorconfig | 7 + .../resources/hudson/PluginManager/_table.css | 74 ---- .../resources/hudson/PluginManager/_table.js | 8 +- .../hudson/PluginManager/advanced.jelly | 144 ++++--- .../hudson/PluginManager/available.jelly | 47 +-- .../hudson/PluginManager/installed.jelly | 385 ++++++++++-------- .../resources/hudson/PluginManager/search.gif | Bin 591 -> 0 bytes .../hudson/PluginManager/table.jelly | 217 ++++++---- .../hudson/widgets/HistoryWidget/index.jelly | 4 +- .../views/JenkinsHeader/headerContent.jelly | 4 +- .../lib/hudson/newFromList/form.jelly | 6 +- .../main/resources/lib/layout/app-bar.jelly | 44 ++ .../main/resources/lib/layout/layout.jelly | 6 +- .../hudson/PluginManagerInstalledGUITest.java | 2 +- war/src/main/js/plugin-manager-ui.js | 16 +- .../js/templates/plugin-manager/available.hbs | 17 +- war/src/main/less/abstracts/theme.less | 1 + war/src/main/less/base-styles-v2.less | 3 + war/src/main/less/base/spacing.less | 45 ++ war/src/main/less/base/style.less | 122 +----- war/src/main/less/base/typography.less | 9 +- war/src/main/less/base/visibility-utils.less | 4 + war/src/main/less/modules/app-bar.less | 6 + war/src/main/less/modules/buttons.less | 11 + war/src/main/less/modules/form.less | 105 +++++ war/src/main/less/modules/page-header.less | 15 +- war/src/main/less/modules/table.less | 17 + war/src/main/less/pages/plugin-manager.less | 100 +++++ war/src/main/less/plugin-manager-ui.less | 105 ----- .../images/ionicons/close-circle-outline.svg | 1 + .../ionicons/downgrade-circle-outline.svg | 5 + .../images/ionicons/help-circle-outline.svg | 1 + .../images/ionicons/search-outline.svg | 1 + war/webpack.config.js | 1 - 34 files changed, 845 insertions(+), 688 deletions(-) create mode 100644 .editorconfig delete mode 100644 core/src/main/resources/hudson/PluginManager/_table.css delete mode 100644 core/src/main/resources/hudson/PluginManager/search.gif create mode 100644 core/src/main/resources/lib/layout/app-bar.jelly create mode 100644 war/src/main/less/base/spacing.less create mode 100644 war/src/main/less/pages/plugin-manager.less delete mode 100644 war/src/main/less/plugin-manager-ui.less create mode 100644 war/src/main/resources/images/ionicons/close-circle-outline.svg create mode 100644 war/src/main/resources/images/ionicons/downgrade-circle-outline.svg create mode 100644 war/src/main/resources/images/ionicons/help-circle-outline.svg create mode 100644 war/src/main/resources/images/ionicons/search-outline.svg diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000000..2e71b15330 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,7 @@ +root = true + +[*.{jelly, js, less, css, hbs}] +indent_style = space +indent_size = 2 +trim_trailing_whitespace = true +insert_final_newline = true diff --git a/core/src/main/resources/hudson/PluginManager/_table.css b/core/src/main/resources/hudson/PluginManager/_table.css deleted file mode 100644 index 5c3bfab450..0000000000 --- a/core/src/main/resources/hudson/PluginManager/_table.css +++ /dev/null @@ -1,74 +0,0 @@ -#filter-box { - padding-left: 35px; - width: 15em; -} - -time { - white-space: nowrap; -} - -#filter-container { - margin: 1em 0; - font-size: 1em; -} -.plugin-manager__categories { - margin-top: 0.25em; -} - -.plugin-manager__search-input { - position: static; - padding: 0.25rem 0.1rem 0.25rem 2.5rem; - margin: 0; - - font-size: 1rem; - line-height: 1.5; - color: #333; - color: var(--text-color); - - border-radius: 4px; - border: 1px solid grey; - outline: none; -} - -.plugin-manager__search { - position: relative; -} - -.plugin-manager__icon-leading { - position: absolute; - left: -2px; - top: -3px; - font-size: 15px; - padding: 0.5rem; -} - -.main-search__icon-leading { - left: 0; - pointer-events: none; -} - - -.hidden-by-default { -} -.hidden { - display: none; -} - -#plugins tr.unavailable { - background-color: #f4f4f4; - background-color: var(--plugin-manager-unavailable-bg-color); -} -tr.unavailable span.unavailable-label { - display: inline-block; - border: 1px solid #666; - color: #333; - border-radius: 4px; - font-size: 0.75rem; - font-weight: 500; - padding: 0 0.5rem; - margin: 0.25rem 0.5rem; - text-decoration: none; - text-align: center; - white-space: nowrap; - vertical-align: baseline; -} diff --git a/core/src/main/resources/hudson/PluginManager/_table.js b/core/src/main/resources/hudson/PluginManager/_table.js index 10af227861..d14b436a4a 100644 --- a/core/src/main/resources/hudson/PluginManager/_table.js +++ b/core/src/main/resources/hudson/PluginManager/_table.js @@ -16,13 +16,14 @@ Behaviour.specify("#filter-box", '_table', 0, function(e) { var anyVisible = false; for (var i=0; i - - + + + + + + -
-
-
-

${%HTTP Proxy Configuration}

- - - - - - - - - - - - -
- -
-

${%Deploy Plugin}

- -
- ${%deploytext} -
- - - -

${%Or}

- - - - -
-
-
+
+

${%HTTP Proxy Configuration}

+ + + + + + + + + + + + +
-
-

${%Update Site}

- - - - - - - - - - - + +
+

${%Deploy Plugin}

+ +
+ ${%deploytext} +
+ + + +

${%Or}

+ + + + +
+
+
+ +
+

${%Update Site}

+ + + + + + + + + + + + + + + + +
+ + +
+

${%Other Sites}

+
    - +
  • ${site.url}
  • -
- - -
-

${%Other Sites}

-
    - - -
  • ${site.url}
  • -
    -
    -
-
-
-
-
-
- -
+ + +
diff --git a/core/src/main/resources/hudson/PluginManager/available.jelly b/core/src/main/resources/hudson/PluginManager/available.jelly index abcd52b911..e22f2f833c 100644 --- a/core/src/main/resources/hudson/PluginManager/available.jelly +++ b/core/src/main/resources/hudson/PluginManager/available.jelly @@ -23,47 +23,42 @@ THE SOFTWARE. --> - + - - -