From ea83e95a71600a6cd65e4c1a6799c32da219dbcf Mon Sep 17 00:00:00 2001 From: tfennelly Date: Wed, 23 Mar 2016 10:30:42 +0000 Subject: [PATCH 1/2] Remove sidepanel from newJob.jelly And set the body element classes via the cssclass attr --- core/src/main/resources/hudson/model/View/newJob.jelly | 3 +-- war/src/main/js/add-item.js | 7 +------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/core/src/main/resources/hudson/model/View/newJob.jelly b/core/src/main/resources/hudson/model/View/newJob.jelly index 31bbdd0c6b..6649443504 100644 --- a/core/src/main/resources/hudson/model/View/newJob.jelly +++ b/core/src/main/resources/hudson/model/View/newJob.jelly @@ -29,12 +29,11 @@ THE SOFTWARE. - + - diff --git a/war/src/main/js/add-item.js b/war/src/main/js/add-item.js index 8fcfd5c8c7..2aea94c21b 100644 --- a/war/src/main/js/add-item.js +++ b/war/src/main/js/add-item.js @@ -29,12 +29,7 @@ $.when(getItems()).done(function(data){ var $tabs = $('
').appendTo($newView); var $categories = $('
').appendTo($newView); var $subBtn = $('#bottom-sticker .yui-submit-button'); - var sectionsToShow = []; - - //////////////////////////////// - // mark page for layout - $('body').addClass('add-item main-panel-only'); - + var sectionsToShow = []; //////////////////////////////// // submit button click From c5170d89f001e5145691b2d92fdd61aede619088 Mon Sep 17 00:00:00 2001 From: tfennelly Date: Wed, 23 Mar 2016 10:40:31 +0000 Subject: [PATCH 2/2] Fix new item page loading weirdness. --- core/src/main/resources/hudson/model/View/newJob.jelly | 3 ++- war/src/main/js/add-item.js | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/core/src/main/resources/hudson/model/View/newJob.jelly b/core/src/main/resources/hudson/model/View/newJob.jelly index 6649443504..eb41acfd62 100644 --- a/core/src/main/resources/hudson/model/View/newJob.jelly +++ b/core/src/main/resources/hudson/model/View/newJob.jelly @@ -35,7 +35,7 @@ THE SOFTWARE. - + diff --git a/war/src/main/js/add-item.js b/war/src/main/js/add-item.js index 2aea94c21b..9b692e17e2 100644 --- a/war/src/main/js/add-item.js +++ b/war/src/main/js/add-item.js @@ -15,6 +15,11 @@ var jRoot = $('head').attr('data-rooturl'); $.when(getItems()).done(function(data){ $(function() { + + // The main panel content is hidden by default via an + // inline style. We're ready to remove that now. + $('#create-item-panel').removeAttr('style'); + ////////////////////////////// // helpful reference DOM