mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-16 13:32:24 +00:00
adding a check for <label for="...">
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@30337 71c3de6d-444a-0410-be80-ed276b4c234a
This commit is contained in:
1 parent
35ab73dc3c
commit
41273a8ecb
1 file changed
+24
@@ -27,6 +27,8 @@ import junit.framework.TestCase;
|
||||
import junit.framework.TestResult;
|
||||
import junit.framework.TestSuite;
|
||||
import org.apache.commons.io.FileUtils;
|
||||
import org.dom4j.Document;
|
||||
import org.dom4j.io.SAXReader;
|
||||
import org.jvnet.hudson.test.junit.GroupedTest;
|
||||
import org.kohsuke.stapler.MetaClassLoader;
|
||||
import org.kohsuke.stapler.jelly.JellyClassLoaderTearOff;
|
||||
@@ -85,8 +87,30 @@ public class JellyTestSuiteBuilder {
|
||||
@Override
|
||||
protected void runTest() throws Exception {
|
||||
jct.createContext().compileScript(jelly);
|
||||
Document dom = new SAXReader().read(jelly);
|
||||
checkLabelFor(dom);
|
||||
// TODO: what else can we check statically? use of taglibs?
|
||||
}
|
||||
|
||||
/**
|
||||
* Makes sure that <label for=...> is not used inside config.jelly nor global.jelly
|
||||
*/
|
||||
private void checkLabelFor(Document dom) {
|
||||
if (isConfigJelly() || isGlobalJelly()) {
|
||||
if (!dom.selectNodes("//label[@for]").isEmpty())
|
||||
throw new AssertionError("<label for='...> shouldn't be used because it doesn't work " +
|
||||
"when th configuration item is repeated. Use <label class='attach-previous'>" +
|
||||
"to have your label attach to the previous DOM node instead.");
|
||||
}
|
||||
}
|
||||
|
||||
private boolean isConfigJelly() {
|
||||
return jelly.toString().endsWith("/config.jelly");
|
||||
}
|
||||
|
||||
private boolean isGlobalJelly() {
|
||||
return jelly.toString().endsWith("/global.jelly");
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in new issue
Block a user