mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-10 10:36:21 +00:00
[JENKINS-16301] Verifying current load/save implementation can round-trip fingerprints.
This commit is contained in:
1 parent
63ecb8269a
commit
41edc5867b
2 files changed
+52
-3
No files matched your search
@@ -578,7 +578,7 @@ public class Fingerprint implements ModelObject, Saveable {
|
||||
*/
|
||||
private final Hashtable<String,RangeSet> usages = new Hashtable<String,RangeSet>();
|
||||
|
||||
private PersistedList<FingerprintFacet> facets = new PersistedList<FingerprintFacet>(this);
|
||||
PersistedList<FingerprintFacet> facets = new PersistedList<FingerprintFacet>(this);
|
||||
|
||||
/**
|
||||
* Lazily computed immutable {@link FingerprintFacet}s created from {@link TransientFingerprintFacetFactory}.
|
||||
@@ -712,7 +712,12 @@ public class Fingerprint implements ModelObject, Saveable {
|
||||
* Records that a build of a job has used this file.
|
||||
*/
|
||||
public synchronized void add(String jobFullName, int n) throws IOException {
|
||||
synchronized(usages) {
|
||||
addWithoutSaving(jobFullName, n);
|
||||
save();
|
||||
}
|
||||
|
||||
void addWithoutSaving(String jobFullName, int n) {
|
||||
synchronized(usages) { // XXX why not synchronized (this) like some, though not all, other accesses?
|
||||
RangeSet r = usages.get(jobFullName);
|
||||
if(r==null) {
|
||||
r = new RangeSet();
|
||||
@@ -720,7 +725,6 @@ public class Fingerprint implements ModelObject, Saveable {
|
||||
}
|
||||
r.add(n);
|
||||
}
|
||||
save();
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in new issue
Block a user