From 52277c5bf2075ffd9db21ff3b112e7cc19adbd05 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 29 Apr 2009 16:31:30 +0000 Subject: [PATCH] Hudson now handles unexpected failures in trigger plugins more gracefully. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@17621 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/triggers/Trigger.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/triggers/Trigger.java b/core/src/main/java/hudson/triggers/Trigger.java index 1ff4d1c497..5851d1547e 100644 --- a/core/src/main/java/hudson/triggers/Trigger.java +++ b/core/src/main/java/hudson/triggers/Trigger.java @@ -225,7 +225,13 @@ public abstract class Trigger implements Describable> if (t.tabs.check(cal)) { LOGGER.config("cron triggered "+p.getName()); - t.run(); + try { + t.run(); + } catch (Throwable e) { + // t.run() is a plugin, and some of them throw RuntimeException and other things. + // don't let that cancel the polling activity. report and move on. + LOGGER.log(Level.WARNING, t.getClass().getName()+".run() failed for "+p.getName(),e); + } } } }