diff --git a/changelog.html b/changelog.html index 13aba769ff..4620974138 100644 --- a/changelog.html +++ b/changelog.html @@ -58,6 +58,9 @@ Upcoming changes
  • Enable word breaking in potentially long strings like job names. (issue 17030) +
  • + Allow filtering of the Run parameter build list by result. + (issue 7280)
  • “Recurse in subfolders” option for list views produced exceptions when used with native Maven projects. (issue 18025) diff --git a/core/src/main/java/hudson/model/RunParameterDefinition.java b/core/src/main/java/hudson/model/RunParameterDefinition.java index 107263f4c9..bacef92a08 100644 --- a/core/src/main/java/hudson/model/RunParameterDefinition.java +++ b/core/src/main/java/hudson/model/RunParameterDefinition.java @@ -38,7 +38,8 @@ import org.kohsuke.stapler.QueryParameter; public class RunParameterDefinition extends SimpleParameterDefinition { /** - * Constants that control how Run Parameter is filtered + * Constants that control how Run Parameter is filtered. + * @since 1.517 */ public enum RunParameterFilter { ALL, @@ -59,6 +60,9 @@ public class RunParameterDefinition extends SimpleParameterDefinition { private final String runId; private final RunParameterFilter filter; + /** + * @since 1.517 + */ @DataBoundConstructor public RunParameterDefinition(String name, String projectName, String description, RunParameterFilter filter) { super(name, description); @@ -103,6 +107,7 @@ public class RunParameterDefinition extends SimpleParameterDefinition { /** * @return The current filter value, if filter is null, returns ALL + * @since 1.517 */ public RunParameterFilter getFilter() { // if filter is null, default to RunParameterFilter.ALL diff --git a/core/src/main/java/hudson/util/RunList.java b/core/src/main/java/hudson/util/RunList.java index 0fc740a3f1..d80397bc93 100644 --- a/core/src/main/java/hudson/util/RunList.java +++ b/core/src/main/java/hudson/util/RunList.java @@ -241,9 +241,9 @@ public class RunList extends AbstractList { } /** - * Filter the list to builds >= threshold. + * Filter the list to builds above threshold. * - * @since 1.516 + * @since 1.517 */ public RunList overThresholdOnly(final Result threshold) { return filter(new Predicate() { diff --git a/test/src/test/java/hudson/model/RunParameterDefinitionTest.java b/test/src/test/java/hudson/model/RunParameterDefinitionTest.java index 1f0e909507..f0b7efe86a 100644 --- a/test/src/test/java/hudson/model/RunParameterDefinitionTest.java +++ b/test/src/test/java/hudson/model/RunParameterDefinitionTest.java @@ -238,7 +238,7 @@ public class RunParameterDefinitionTest { static class ResultPublisher extends Publisher { - private Result result = Result.FAILURE; + private final Result result; public ResultPublisher(Result result) { this.result = result;