From 56be107feb24ab3470efae7603041bbbb9cdf7fb Mon Sep 17 00:00:00 2001 From: Daniel Beck Date: Mon, 25 Apr 2016 21:06:54 +0200 Subject: [PATCH] [FIX SECURITY-273] Require admin permission to check update sites --- core/src/main/java/hudson/PluginManager.java | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index b7cb78fedf..9d89d4acec 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -889,6 +889,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas @Restricted(NoExternalUse.class) @RequirePOST public HttpResponse doCheckUpdatesServer() throws IOException { + Jenkins.getInstance().checkPermission(Jenkins.ADMINISTER); for (UpdateSite site : Jenkins.getInstance().getUpdateCenter().getSites()) { FormValidation v = site.updateDirectlyNow(DownloadService.signatureCheck); if (v.kind != FormValidation.Kind.OK) {