diff --git a/core/src/main/java/hudson/PluginWrapper.java b/core/src/main/java/hudson/PluginWrapper.java index 75322ab32a..ef73feea6f 100644 --- a/core/src/main/java/hudson/PluginWrapper.java +++ b/core/src/main/java/hudson/PluginWrapper.java @@ -465,10 +465,7 @@ public class PluginWrapper implements Comparable, ModelObject { */ @Exported public @CheckForNull String getRequiredJavaVersion() { - String v = manifest.getMainAttributes().getValue("Minimum-Java-Version"); - if (v!= null) return v; - - return null; + return manifest.getMainAttributes().getValue("Minimum-Java-Version"); } /** @@ -617,8 +614,8 @@ public class PluginWrapper implements Comparable, ModelObject { String requiredJavaVersion = getRequiredJavaVersion(); if (requiredJavaVersion != null) { - // TODO replace with calls to Runtime.version() once we're on Java 9 - VersionNumber actualVersion = new VersionNumber(System.getProperty("java.version")); + // TODO replace with calls to Runtime.version() once we're on Java 9+ + VersionNumber actualVersion = new VersionNumber(System.getProperty("java.specification.version")); if (actualVersion.isOlderThan(new VersionNumber(requiredJavaVersion))) { dependencyErrors.add(Messages.PluginWrapper_obsoleteJava(actualVersion.toString(), requiredJavaVersion)); } diff --git a/core/src/main/java/hudson/model/UpdateSite.java b/core/src/main/java/hudson/model/UpdateSite.java index 0812aa7c44..b1950c8131 100644 --- a/core/src/main/java/hudson/model/UpdateSite.java +++ b/core/src/main/java/hudson/model/UpdateSite.java @@ -1117,7 +1117,7 @@ public class UpdateSite { public boolean isForNewerJava() { try { return requiredJava != null && new VersionNumber(requiredJava).isNewerThan( - new VersionNumber(System.getProperty("java.version"))); + new VersionNumber(System.getProperty("java.specification.version"))); } catch (NumberFormatException nfe) { return false; // plugin doesn't declare a minimum Java version }