From 5ce67c3b5ce15f72734c800dc06e97dfb051cc46 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Tue, 16 Dec 2008 21:38:12 +0000 Subject: [PATCH] Updated the comment after seeing http://www.nabble.com/SYSTEM-authentication-td20988049.html git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@13657 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/security/ACL.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/hudson/security/ACL.java b/core/src/main/java/hudson/security/ACL.java index 2414577d97..32950e792c 100644 --- a/core/src/main/java/hudson/security/ACL.java +++ b/core/src/main/java/hudson/security/ACL.java @@ -5,8 +5,8 @@ import org.acegisecurity.Authentication; import org.acegisecurity.providers.UsernamePasswordAuthenticationToken; import org.acegisecurity.acls.sid.PrincipalSid; import org.acegisecurity.acls.sid.Sid; -import org.acegisecurity.context.SecurityContextHolder; import hudson.model.Hudson; +import hudson.model.Executor; /** * Gate-keeper that controls access to Hudson's model objects. @@ -78,10 +78,9 @@ public abstract class ACL { * of acting on behalf of an user, such as doing builds. * *

- * Technically speaking, this is probably a broken concept, because Hudson never - * does anything on its own; for example, it builds a project because someone - * configures it or someone triggers it, so ideally Hudson should be impersonating - * that user when executing things. + * (Note that one of the features being considered is to keep track of who triggered + * a build — so in a future, perhaps {@link Executor} will run on behalf of + * the user who triggered a build.) */ public static final Authentication SYSTEM = new UsernamePasswordAuthenticationToken("SYSTEM","SYSTEM"); }