diff --git a/core/src/main/java/hudson/ProxyConfiguration.java b/core/src/main/java/hudson/ProxyConfiguration.java index f1b7011f42..7c2809c53f 100644 --- a/core/src/main/java/hudson/ProxyConfiguration.java +++ b/core/src/main/java/hudson/ProxyConfiguration.java @@ -62,6 +62,7 @@ import org.jenkinsci.Symbol; import org.jvnet.robust_http_client.RetryableHttpStream; import org.kohsuke.stapler.DataBoundConstructor; import org.kohsuke.stapler.QueryParameter; +import org.kohsuke.stapler.interceptor.RequirePOST; /** * HTTP proxy configuration. @@ -334,6 +335,7 @@ public final class ProxyConfiguration extends AbstractDescribableImpl extends SlaveCo * When the agent is deleted, free the node right away. */ @Override + @RequirePOST public HttpResponse doDoDelete() throws IOException { checkPermission(DELETE); try { diff --git a/core/src/main/java/hudson/util/DoubleLaunchChecker.java b/core/src/main/java/hudson/util/DoubleLaunchChecker.java index 091319f712..8bbcdcab08 100644 --- a/core/src/main/java/hudson/util/DoubleLaunchChecker.java +++ b/core/src/main/java/hudson/util/DoubleLaunchChecker.java @@ -30,6 +30,7 @@ import jenkins.util.Timer; import org.apache.commons.io.FileUtils; import org.kohsuke.stapler.StaplerRequest; import org.kohsuke.stapler.StaplerResponse; +import org.kohsuke.stapler.interceptor.RequirePOST; import javax.servlet.ServletException; import javax.servlet.ServletContext; @@ -174,6 +175,7 @@ public class DoubleLaunchChecker { /** * Ignore the problem and go back to using Hudson. */ + @RequirePOST public void doIgnore(StaplerRequest req, StaplerResponse rsp) throws IOException { ignore = true; Jenkins.getInstance().servletContext.setAttribute("app", Jenkins.getInstance()); diff --git a/core/src/main/java/jenkins/diagnosis/HsErrPidFile.java b/core/src/main/java/jenkins/diagnosis/HsErrPidFile.java index 39d5425aac..8d86a6b13c 100644 --- a/core/src/main/java/jenkins/diagnosis/HsErrPidFile.java +++ b/core/src/main/java/jenkins/diagnosis/HsErrPidFile.java @@ -4,6 +4,7 @@ import hudson.Util; import hudson.util.HttpResponses; import jenkins.model.Jenkins; import org.kohsuke.stapler.HttpResponse; +import org.kohsuke.stapler.interceptor.RequirePOST; import java.io.File; import java.io.IOException; @@ -48,6 +49,7 @@ public class HsErrPidFile { return HttpResponses.staticResource(file); } + @RequirePOST public HttpResponse doDelete() throws IOException { Jenkins.getInstance().checkPermission(Jenkins.ADMINISTER); file.delete(); diff --git a/core/src/main/java/jenkins/install/SetupWizard.java b/core/src/main/java/jenkins/install/SetupWizard.java index 74ef40624e..7429955b01 100644 --- a/core/src/main/java/jenkins/install/SetupWizard.java +++ b/core/src/main/java/jenkins/install/SetupWizard.java @@ -458,6 +458,7 @@ public class SetupWizard extends PageDecorator { /** * Remove the setupWizard filter, ensure all updates are written to disk, etc */ + @RequirePOST public HttpResponse doCompleteInstall() throws IOException, ServletException { completeSetup(); return HttpResponses.okJSON(); diff --git a/core/src/main/resources/hudson/model/TaskAction/log.jelly b/core/src/main/resources/hudson/model/TaskAction/log.jelly index 388f4d6393..f7be5cfb7a 100644 --- a/core/src/main/resources/hudson/model/TaskAction/log.jelly +++ b/core/src/main/resources/hudson/model/TaskAction/log.jelly @@ -42,7 +42,7 @@ THE SOFTWARE. ${it.obtainLog().writeLogTo(0,output)} -
+ diff --git a/core/src/main/resources/hudson/util/DoubleLaunchChecker/index.jelly b/core/src/main/resources/hudson/util/DoubleLaunchChecker/index.jelly index d126380218..cfbbda0abd 100644 --- a/core/src/main/resources/hudson/util/DoubleLaunchChecker/index.jelly +++ b/core/src/main/resources/hudson/util/DoubleLaunchChecker/index.jelly @@ -45,7 +45,7 @@ THE SOFTWARE.
-
+
diff --git a/war/src/main/js/api/pluginManager.js b/war/src/main/js/api/pluginManager.js index 04d754f0e7..f1cf8ac0f3 100644 --- a/war/src/main/js/api/pluginManager.js +++ b/war/src/main/js/api/pluginManager.js @@ -177,7 +177,7 @@ exports.incompleteInstallStatus = function(handler, correlationId) { * Call this to complete the installation without installing anything */ exports.completeInstall = function(handler) { - jenkins.get('/setupWizard/completeInstall', function() { + jenkins.post('/setupWizard/completeInstall', {}, function() { handler.call({ isError: false }); }, { timeout: pluginManagerErrorTimeoutMillis,