JENKINS-36720: Fixed some spotbugs findings (SE_NO_SERIALVERSIONID, CO_COMPARETO_INCORRECT_FLOATING, VA_FORMAT_STRING_USES_NEWLINE)

This commit is contained in:
Stefan Spieker committed 2019-07-28 10:36:32 +02:00
1 parent aee0b50f3b
commit 681420bb4f
7 files changed
+16 -8

No files matched your search

@@ -88,8 +88,8 @@ public class ExtensionComponent<T> implements Comparable<ExtensionComponent<T>>
public int compareTo(ExtensionComponent<T> that) {
double a = this.ordinal();
double b = that.ordinal();
if (a>b) return -1;
if (a<b) return 1;
if (Double.compare(a, b) > 0) return -1;
if (Double.compare(a, b) < 0) return 1;
// make the order bit more deterministic among extensions of the same ordinal
if (this.instance instanceof Descriptor && that.instance instanceof Descriptor) {