From 6b7bf02136cbf1526a5b19d3f7a3fffd6767f787 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Wed, 6 Aug 2008 21:37:41 +0000 Subject: [PATCH] making FindBugs happier git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@11309 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/scm/CVSSCM.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/hudson/scm/CVSSCM.java b/core/src/main/java/hudson/scm/CVSSCM.java index 36cfdc4058..9e1f660b06 100644 --- a/core/src/main/java/hudson/scm/CVSSCM.java +++ b/core/src/main/java/hudson/scm/CVSSCM.java @@ -51,7 +51,6 @@ import java.io.IOException; import java.io.InputStreamReader; import java.io.OutputStream; import java.io.PrintWriter; -import java.io.Reader; import java.io.Serializable; import java.io.StringWriter; import java.text.DateFormat; @@ -589,9 +588,9 @@ public class CVSSCM extends SCM implements Serializable { File tag = new File(cvs,"Tag"); if (tag.exists()) { try { - Reader r = new FileReader(tag); + BufferedReader r = new BufferedReader(new FileReader(tag)); try { - String s = new BufferedReader(r).readLine(); + String s = r.readLine(); return s != null && s.startsWith("D"); } finally { r.close(); @@ -612,9 +611,9 @@ public class CVSSCM extends SCM implements Serializable { */ private boolean checkContents(File file, String contents) { try { - Reader r = new FileReader(file); + BufferedReader r = new BufferedReader(new FileReader(file)); try { - String s = new BufferedReader(r).readLine(); + String s = r.readLine(); if (s == null) return false; return massageForCheckContents(s).equals(massageForCheckContents(contents)); } finally {