From 6ffc57ae79cabcd4083517fb66d2af91dd8fad12 Mon Sep 17 00:00:00 2001
From: Jesse Glick <jglick@cloudbees.com>
Date: Thu, 6 Apr 2017 15:58:23 -0400
Subject: [PATCH] Verifying that PlainCLIProtocol ignores unrecognized opcodes,
 so long as it has received well-formed frames.

---
 .../java/hudson/cli/PlainCLIProtocolTest.java | 132 ++++++++++++++++++
 1 file changed, 132 insertions(+)
 create mode 100644 cli/src/test/java/hudson/cli/PlainCLIProtocolTest.java

diff --git a/cli/src/test/java/hudson/cli/PlainCLIProtocolTest.java b/cli/src/test/java/hudson/cli/PlainCLIProtocolTest.java
new file mode 100644
index 0000000000..4663fbafd5
--- /dev/null
+++ b/cli/src/test/java/hudson/cli/PlainCLIProtocolTest.java
@@ -0,0 +1,132 @@
+/*
+ * The MIT License
+ *
+ * Copyright 2017 CloudBees, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+
+package hudson.cli;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.io.PipedInputStream;
+import java.io.PipedOutputStream;
+import static org.junit.Assert.*;
+import org.junit.Test;
+
+public class PlainCLIProtocolTest {
+
+    @Test
+    public void ignoreUnknownOperations() throws Exception {
+        final PipedOutputStream upload = new PipedOutputStream();
+        final PipedOutputStream download = new PipedOutputStream();
+        class Client extends PlainCLIProtocol.ClientSide {
+            int code = -1;
+            final ByteArrayOutputStream stdout = new ByteArrayOutputStream();
+            Client() throws IOException {
+                super(new PipedInputStream(download), upload);
+            }
+            @Override
+            protected synchronized void onExit(int code) {
+                this.code = code;
+                notifyAll();
+            }
+            @Override
+            protected void onStdout(byte[] chunk) throws IOException {
+                stdout.write(chunk);
+            }
+            @Override
+            protected void onStderr(byte[] chunk) throws IOException {}
+            @Override
+            protected void handleClose() {}
+            void send() throws IOException {
+                sendArg("command");
+                sendStart();
+                streamStdin().write("hello".getBytes());
+            }
+            void newop() throws IOException {
+                dos.writeInt(0);
+                dos.writeByte(99);
+                dos.flush();
+            }
+        }
+        class Server extends PlainCLIProtocol.ServerSide {
+            String arg;
+            boolean started;
+            final ByteArrayOutputStream stdin = new ByteArrayOutputStream();
+            Server() throws IOException {
+                super(new PipedInputStream(upload), download);
+            }
+            @Override
+            protected void onArg(String text) {
+                arg = text;
+            }
+            @Override
+            protected void onLocale(String text) {}
+            @Override
+            protected void onEncoding(String text) {}
+            @Override
+            protected synchronized void onStart() {
+                started = true;
+                notifyAll();
+            }
+            @Override
+            protected void onStdin(byte[] chunk) throws IOException {
+                stdin.write(chunk);
+            }
+            @Override
+            protected void onEndStdin() throws IOException {}
+            @Override
+            protected void handleClose() {}
+            void send() throws IOException {
+                streamStdout().write("goodbye".getBytes());
+                sendExit(2);
+            }
+            void newop() throws IOException {
+                dos.writeInt(0);
+                dos.writeByte(99);
+                dos.flush();
+            }
+        }
+        Client client = new Client();
+        Server server = new Server();
+        client.begin();
+        server.begin();
+        client.send();
+        client.newop();
+        synchronized (server) {
+            while (!server.started) {
+                server.wait();
+            }
+        }
+        server.newop();
+        server.send();
+        synchronized (client) {
+            while (client.code == -1) {
+                client.wait();
+            }
+        }
+        assertEquals("hello", server.stdin.toString());
+        assertEquals("command", server.arg);
+        assertEquals("goodbye", client.stdout.toString());
+        assertEquals(2, client.code);
+    }
+
+}