From f98857b3bc18ac114cdfadef9a999120e3b32a0c Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Mon, 7 May 2012 17:29:53 -0700 Subject: [PATCH] fixed a test failure --- .../test/java/hudson/model/DirectoryBrowserSupportTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java b/test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java index bd65a8322c..c27b2ad18d 100644 --- a/test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java +++ b/test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java @@ -64,7 +64,9 @@ public class DirectoryBrowserSupportTest extends HudsonTestCase { } /** - * Also makes sure '\\' in the file name for Unix is handled correctly. + * Also makes sure '\\' in the file name for Unix is handled correctly. + * + * To prevent directory traversal attack, we now treat '\\' just like '/'. */ @Email("http://www.nabble.com/Status-Code-400-viewing-or-downloading-artifact-whose-filename-contains-two-consecutive-periods-tt21407604.html") public void testDoubleDots2() throws Exception { @@ -72,7 +74,7 @@ public class DirectoryBrowserSupportTest extends HudsonTestCase { // create a problematic file name in the workspace FreeStyleProject p = createFreeStyleProject(); - p.getBuildersList().add(new Shell("touch abc\\\\def.bin")); + p.getBuildersList().add(new Shell("mkdir abc; touch abc/def.bin")); p.scheduleBuild2(0).get(); // can we see it?