From 81c3249ca0e6bcc69e1caa2e6828ec6c8c0884cd Mon Sep 17 00:00:00 2001
From: Mark Waite <mark.earl.waite@gmail.com>
Date: Tue, 2 Jan 2024 01:11:15 -0700
Subject: [PATCH] Use spotbugs 4.8.2 with more exclusions (#8803)

---
 core/src/spotbugs/excludesFilter.xml | 123 +++++++++++++++++++++++++++
 pom.xml                              |   4 +
 2 files changed, 127 insertions(+)

diff --git a/core/src/spotbugs/excludesFilter.xml b/core/src/spotbugs/excludesFilter.xml
index af99fff505..7d36952fc3 100644
--- a/core/src/spotbugs/excludesFilter.xml
+++ b/core/src/spotbugs/excludesFilter.xml
@@ -53,6 +53,125 @@
     <Bug pattern="SF_SWITCH_NO_DEFAULT"/>
     <Class name="hudson.scheduler.CrontabParser"/>
   </Match>
+  <Match>
+    <!-- Preserve API compatibility -->
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.PluginManager"/>
+    <Field name="pluginUploaded"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.ProxyConfiguration"/>
+    <Field name="noProxyHost"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.cli.CLICommand"/>
+    <Or>
+      <Field name="locale"/>
+      <Field name="stderr"/>
+      <Field name="stdin"/>
+      <Field name="stdout"/>
+    </Or>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.cli.CopyJobCommand"/>
+    <Field name="dst"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.cli.CreateJobCommand"/>
+    <Field name="name"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.cli.SetBuildDescriptionCommand"/>
+    <Field name="description"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.cli.SetBuildDisplayNameCommand"/>
+    <Field name="displayName"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.model.Job"/>
+    <Field name="runIdMigrator"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.model.StringParameterValue"/>
+    <Field name="value"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.security.Permission"/>
+    <Field name="enabled"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.tasks.Maven"/>
+    <Field name="usePrivateRepository"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.util.Graph"/>
+    <Field name="defaultScale"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.widgets.HistoryWidget"/>
+    <Field name="baseList"/>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="jenkins.model.Jenkins"/>
+    <Or>
+      <Field name="tcpSlaveAgentListener"/>
+      <Field name="proxy"/>
+      <Field name="VERSION"/>
+      <Field name="CHANGELOG_URL"/>
+      <Field name="VERSION_HASH"/>
+      <Field name="SESSION_HASH"/>
+      <Field name="RESOURCE_PATH"/>
+      <Field name="VIEW_RESOURCE_PATH"/>
+    </Or>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="jenkins.widgets.HistoryPageFilter"/>
+    <Or>
+      <Field name="hasDownPage"/>
+      <Field name="hasUpPage"/>
+      <Field name="newestOnPage"/>
+      <Field name="nextBuildNumber"/>
+      <Field name="oldestOnPage"/>
+    </Or>
+  </Match>
+  <Match>
+    <Bug pattern="PA_PUBLIC_PRIMITIVE_ATTRIBUTE"/>
+    <Class name="hudson.slaves.JNLPLauncher"/>
+    <Field name="tunnel"/>
+  </Match>
+  <Match>
+    <!-- Reserved for future use -->
+    <Bug pattern="SS_SHOULD_BE_STATIC"/>
+    <Class name="hudson.model.User"/>
+    <Field name="version"/>
+  </Match>
+  <Match>
+    <!-- Reserved for future use -->
+    <Bug pattern="SS_SHOULD_BE_STATIC"/>
+    <Class name="hudson.model.UserIdMapper"/>
+    <Field name="version"/>
+  </Match>
+  <Match>
+    <!-- Reserved for future use -->
+    <Bug pattern="SS_SHOULD_BE_STATIC"/>
+    <Class name="hudson.util.Graph"/>
+    <Field name="defaultScale"/>
+  </Match>
   <!--
     Here lies technical debt. Exclusions in this section have not yet been triaged. When working on
     on this section, pick an exclusion to triage, then:
@@ -377,4 +496,8 @@
       </And>
     </Or>
   </Match>
+  <Match>
+    <Bug pattern="SIC_INNER_SHOULD_BE_STATIC"/>
+    <Class name="jenkins.security.stapler.StaplerDispatchValidator$ValidatorCache$Validator"/>
+  </Match>
 </FindBugsFilter>
diff --git a/pom.xml b/pom.xml
index 9de262dcd3..cd28d0f7b0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -90,7 +90,11 @@ THE SOFTWARE.
     <!-- Minimum Remoting version, which is tested for API compatibility -->
     <remoting.minimum.supported.version>4.13</remoting.minimum.supported.version>
 
+    <!-- TODO: Remove when parent pom is using this version or newer -->
+    <!-- https://github.com/jenkinsci/pom/pull/510 -->
+    <spotbugs-maven-plugin.version>4.8.2.0</spotbugs-maven-plugin.version>
     <spotbugs.effort>Max</spotbugs.effort>
+    <spotbugs.omitVisitors>FindReturnRef,ConstructorThrow</spotbugs.omitVisitors>
     <spotbugs.threshold>Medium</spotbugs.threshold>
 
     <access-modifier.version>1.33</access-modifier.version>