From 891bdbeafe46600a93df299a65f3371f1f4b85fe Mon Sep 17 00:00:00 2001
From: Emrullah YILDIRIM <emrullahyildirim@windowslive.com>
Date: Sat, 3 Oct 2020 15:37:08 +0300
Subject: [PATCH] Performance issue, string concatenation in  loop

---
 core/src/main/java/hudson/Functions.java | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/core/src/main/java/hudson/Functions.java b/core/src/main/java/hudson/Functions.java
index 7d0ec6cac0..fa254763db 100644
--- a/core/src/main/java/hudson/Functions.java
+++ b/core/src/main/java/hudson/Functions.java
@@ -1301,10 +1301,10 @@ public class Functions {
         }
 
         Item i=p;
-        String url = "";
+        StringBuilder url = new StringBuilder();
         while(true) {
             ItemGroup ig = i.getParent();
-            url = i.getShortUrl()+url;
+            url.insert(0, i.getShortUrl());
 
             if(ig== Jenkins.get() || (view != null && ig == view.getOwner().getItemGroup())) {
                 assert i instanceof TopLevelItem;
@@ -1515,11 +1515,10 @@ public class Functions {
                                              (grp != null ? grp : "?") + " " +
                                              ti.getThreadState());
         if (ti.getLockName() != null) {
-            sb.append(" on " + ti.getLockName());
+            sb.append(" on ").append(ti.getLockName());
         }
         if (ti.getLockOwnerName() != null) {
-            sb.append(" owned by \"" + ti.getLockOwnerName() +
-                      "\" Id=" + ti.getLockOwnerId());
+            sb.append(" owned by \"").append(ti.getLockOwnerName()).append("\" Id=").append(ti.getLockOwnerId());
         }
         if (ti.isSuspended()) {
             sb.append(" (suspended)");
@@ -1562,7 +1561,7 @@ public class Functions {
 
        LockInfo[] locks = ti.getLockedSynchronizers();
        if (locks.length > 0) {
-           sb.append("\n\tNumber of locked synchronizers = " + locks.length);
+           sb.append("\n\tNumber of locked synchronizers = ").append(locks.length);
            sb.append('\n');
            for (LockInfo li : locks) {
                sb.append("\t- ").append(li);